[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#850887: Decide proper solution for binutils' mips* bug



Dropping the TC bug because I think this reply is not relevant to it.

On jueves, 12 de enero de 2017 15:22:14 ART James Cowgill wrote:
> Hi,
> 
> On 12/01/17 14:54, Lisandro Damián Nicanor Pérez Meyer wrote:
> > I would like to point out that it would be preferable if, in case a patch
> > is preferable over going back to the last know version to work, either
> > Matthias or a mips porter points out which of the two proposed patches is
> > preferable.
> > 
> > For the time being I'm testing the patch I submited to the bug, but I have
> > no preference over any of them (nor technical grounds to discuss).
> 
> Both patches posted in the upstream bug should work. The first one fixes
> a bug in the MIPS back end so that local symbols are sorted before
> global symbols. This is probably the safer (although larger) patch
> because it only touches the MIPS back end to try and bring it into line
> with other architectures. The second patch prevents the questionable
> local symbols from every appearing (so no sorting is necessary). This
> should also be correct, although it will visibly change the contents of
> the dynamic symbol table on all arches so I am slightly more
> apprehensive because of that.

I see, good point.

> Side note: the patch you uploaded is not totally correct because it
> isn't applied when building cross binutils (__mips__ will not be defined
> there).

Ah, wonderful to learn that! *Thanks* a lot, I think I'll need this sooner 
than later.


-- 
You are the Doc, Doc!
  Marty McFly To Dr. Emmett Brown, Back to the Future III

Lisandro Damián Nicanor Pérez Meyer
http://perezmeyer.com.ar/
http://perezmeyer.blogspot.com/

Attachment: signature.asc
Description: This is a digitally signed message part.


Reply to: