[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: kernel vs binutils



On Wed, Aug 29, 2001 at 08:43:10AM -0400, Christopher C. Chimelis wrote:
> 
> On Wed, 29 Aug 2001, Guido Guenther wrote:
> 
> > 2.11.90.0.25 worked for me too. In fact the kernel-images in the debian
> > archive were build with .25. Things broke after that.
> 
> Hmmm...very odd.  And there's enough time difference in the snapshots to
> make it harder to track down.  I'll see what I can find out.
I think this is what breaks things:

2001-08-03  Richard Sandiford  <rsandifo@redhat.com>

        * config/tc-mips.c (md_apply_fix): Don't subtract the symbol value from GPREL addends.

When I revert the patch like below things work again.
 -- Guido

Index: gas/config/tc-mips.c
===================================================================
RCS file: /cvs/src/src/gas/config/tc-mips.c,v
retrieving revision 1.57
retrieving revision 1.56
diff -u -u -r1.57 -r1.56
--- gas/config/tc-mips.c	2001/08/03 18:33:34	1.57
+++ gas/config/tc-mips.c	2001/08/02 10:15:24	1.56
@@ -9527,9 +9527,7 @@
 	{
 	  valueT symval = S_GET_VALUE (fixP->fx_addsy);
 	  value -= symval;
-	  if (value != 0
-	      && ! fixP->fx_pcrel
-	      && fixP->fx_r_type != BFD_RELOC_MIPS_GPREL)
+	  if (value != 0 && ! fixP->fx_pcrel)
 	    {
 	      /* In this case, the bfd_install_relocation routine will
 		 incorrectly add the symbol value back in.  We just want
	



Reply to: