Control: tags -1 moreinfo -confirmed
Hi John
(incomplete review, especially did not do a copyright review)
d/copyright: It is not recommended to have a different license for
debian/* and upstream. I'd recommend to align the debian/* license to
the upstream license. (It can create difficulties upstreaming patches,
for example, as Apache and GPL-2 is not considered to be compatible.
d/control:
If a versioned Build-Depends is fulfiled sinc at least oldstable, please
remove the version constraint on the B-D. Thats e.g for cmake,
libboost-all-dev and libssl-dev
Regarding libboost-all-dev: Do you really neeed "all-dev" or can you
limit the B-Ds to the parts of boost you really need?
d/*install - please use ${DEB_HOST_MULTIARCH} instead of "*" for the
architecture triplet.
(/usr/lib/*/*.so will become /usr/lib/${DEB_HOST_MULTIARCH}/*.so
package-name-doesnt-match-sonames is a valid lintian concern.
Don't override, name the package according to Debian Policy.
Cheers,