[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1110157: RFS: robotraconteur/1.2.5-1 [ITP] - communication framework for robotics and automation



Control: tags -1 moreinfo -confirmed


Hi John

(incomplete review, especially did not do a copyright review)
(Basically same findings as in #1110158)

d/copyright: It is not recommended to have a different license for
debian/* and upstream. I'd recommend to align the debian/* license to
the upstream license. (It can create difficulties upstreaming patches,
for example, as Apache and GPL-2 is not considered to be compatible.

d/control:
If a versioned Build-Depends is fulfiled sinc at least oldstable, please
remove the version constraint on the B-D. Thats e.g for cmake,
libboost-all-dev and libssl-dev
Regarding libboost-all-dev: Do you really neeed "all-dev" or can you
limit the B-Ds to the parts of boost you really need?

d/*install - please use ${DEB_HOST_MULTIARCH} instead of "*" for the
architecture triplet.
(/usr/lib/*/*.so will become /usr/lib/${DEB_HOST_MULTIARCH}/*.so

Cheers,
-- 
tobi


On Wed, Jul 30, 2025 at 06:26:11PM -0400, John Wason wrote:
> Package: sponsorship-requests
> Severity: wishlist
> 
> Dear mentors,
> 
> I am looking for a sponsor for my package "robotraconteur"
> 
>  * Package name     : robotraconteur
>    Version          : 1.2.5-5
>    Upstream contact : John Wason <wason@wasontech.com>
>  * URL              : https://github.com/robotraconteur/robotraconteur
>  * License          : Apache-2.0
>  * Vcs              : https://github.com/robotraconteur/robotraconteur.git
>    Section          : libs
> 
> 
> 
> The source builds the following binary packages:
> 
>     * librobotraconteurcore1 - Robot Raconteur is a communication framework
> for
>     * librobotraconteur-dev - Robot Raconteur is a communication framework
> for
>     * python3-robotraconteur - Robot Raconteur Python module
>     * robotraconteurgen - Robot Raconteur is a communication framework for
> 
> To access further information about this package, please visit the following
> URL:
> 
>   https://mentors.debian.net/package/robotraconteur/
> 
> Alternatively, you can download the package with 'dget' using this command:
> 
>   dget -x https://mentors.debian.net/debian/pool/contrib/r/robotraconteur/robotraconteur_1.2.5-5.dsc
> 
> See ITP bug: 1110148:
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1110148
> 
> Changes since revision 1 upload:
> 
> * Update to use debhelper-compat 13
> * Fix sections to use main
> * Improve package descriptions
> * Fix copyright dates and contacts
> * Remove unnecessary --parallel switch from rules
> * Fix multi-arch for packages
> * Add watch file for upstream releases
> * Fix trailing whitespaces
> * Fix librobotraconteur-dev runtime library dependency version
> * Add upstream metadata file
> * Add watch file for upstream releases
> 
> 
> 
> Regards,
> 
> -- 
> John Wason
> 


Reply to: