Bug#1121093: RFS: budgie-desktop-services/0.0.1-1 [ITP] -- Core package for all Budgie Desktop related services
1. I don't like the generic name for /etc/xdg/autostart/autostart .
Could that file be named something other than autostart? Notably,
files in /etc/ are usually conf files and don't get automatically
removed when the package providing them is either removed or stops
shipping that filename.
2. Could the src/dbus/generated/* files be generated by the Debian build?
Maybe those files could be generated by the upstream build system (for
everyone) instead of being generated by Taskfile.yml and checked in to
git.
If there isn't a new release without those generated files, I suggest
adding the files to Files-Excluded: in debian/copyright and excluding
them from your orig tarball. That way you make sure that you are
building those files from source and you don't have to mention them
later in debian/copyright.
I don't consider the following issues to be blockers for uploading.
3. Your Vcs links in debian/control don't work. I recommend not
mentioning a branch name since the default branch is set correctly
already.
4. The Repository* links in debian/upstream/metadata are pointing to
the issues page instead of to the repo. You could maybe add a
Bug-Submit line also.
5. https://moderndesktop.dev/ wasn't loading for me today
Thank you,
Jeremy Bícha
Reply to: