Hi,
(Partial review only, as too many undocumented changes. Please let us know *why* you are changing stuff in d/changelog.)
The debian/ folder in HiPerConTracer's Git repository is intended to work with for different versions of Ubuntu (for Launchpad PPA uploads), as well as for Debian. To create the Debian version, the builder script (https://github.com/dreibh/build-tools) should actually fetch the official Debian changelog of the last Debian upload (1.6.7) and then create a single, merged changelog entry for the new changes on top. Something is wrong with this script, and the output contains unwanted Ubuntu PPA changelog entries instead of the Debian variant. I need to further debug and fix this.
d/changelog:
- Don't have entries that have not been in Debian.
- Remove those never uploaded "New upstream release" entries.
- For the ones in Debian: You're rewriting history: The changelog in the archive is different
than yours,
- Interestinly, the changelog in the archives is missing the intial
upload: https://tracker.debian.org/news/1281874/accepted-hipercontracer-163-1-source-i386-into-unstable-unstable/
When fixing the changelog, please make sure to retain the changelog
entry of the initial upload.
- There are *LOTS* of undocumented changes, e.g changes to d/control,
d/copyright and many other files in d/
(This makes it very hard to review the package)
d/control:
- You change binary package names, libary package name, etc. Why?
You are changeing SONAME - Do you need a library transistion? I
think you want to target experimental first to clear NEW.
HiPerConTracer 2.x is in large parts a complete rewrite of HiPerConTracer 1.x. Particularly, it contains new libraries and tools as sub-packages, which made a redesign of the packaging structure useful.
- The requested chang from https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1095157#110
has not been implemented. The VCS field need to point where the *Debian
packging* is happening.
d/lib*.install
- Use usr/lib/${DEB_HOST_MULTIARCH}/ instead of usr/lib/*/ for
multiarch paths.
For the next mentors' server upload, I am going to remove the Vcs-*
entries and change the library paths.
-- Best regards / Mit freundlichen Grüßen / Med vennlig hilsen ======================================================================= Thomas Dreibholz Simula Metropolitan Centre for Digital Engineering Centre for Resilient Networks and Applications Stensberggata 27 0160 Oslo, Norway ----------------------------------------------------------------------- E-Mail: dreibh@simula.no Homepage: http://simula.no/people/dreibh =======================================================================
Attachment:
OpenPGP_signature.asc
Description: OpenPGP digital signature