Bug#974209: RFS: human-theme-gtk/2.6.0-1 [ITP] -- Human theme for GTK
1. gtk2 is on its way out of Debian so please do not install the gtk2
themes in Debian.
2. Please don't recommend gtk2-engines-murrine since it will be
removed from Debian soon. Please remove all the Suggests.
libqt5gui5t64 Recommends: qt5-gtk-platformtheme
libqt6gui6 Recommends: qt6-gtk-platformtheme
which means that all Qt apps already pull that package in
3. Please don't recommend gnome-icon-theme. See https://bugs.debian.org/1103556
You could set IconTheme=Adwaita . gtk3 and gtk4 already install
adwaita-icon-theme by default.
4. Please don't install your /etc/profile.d/ script. It will silently
change people's systems and it won't be obvious how to undo it. Note
that files installed to /etc/ are usually conf files and are not
automatically removed.
5. The Vcs fields in debian/control are meant to point to where the
Debian packaging is, not the upstream source.
6. I suggest not mentioning package versions in your package
description. There is only one major version of gtk3 : 3.24. We're not
doing gtk2 any more. Debian's gtk4 is much newer than 4.12. And Debian
has a sufficient version of pango.
7. If you add this line to debian/upstream/metadata, you can remove
your debian/watch file as newer versions of uscan will handle it
automatically.
Archive: GitHub
8. This is trivial, but the hardening flag line can be omitted from
debian/rules since you aren't compiling code (C or similar).
Thank you,
Jeremy Bícha
Reply to: