Bug#1120830: RFS: tslib/1.24-1 [ITA] -- touch screen library utilities
hi Tobias,
Am Montag, dem 17.11.2025 um 18:41 +0100 schrieb Tobias Frost:
> Control: tags -1 moreinfo
>
> Hi Martin,
>
> a quick review, a few changes would be appreciated, e.g the changelog
> thing-
>
> On Mon, Nov 17, 2025 at 07:28:10AM +0000, Martin Kepplinger wrote:
> > Package: sponsorship-requests
> > Severity: normal
> >
> > Dear mentors,
> >
> > I am looking for a sponsor for my package "tslib":
> >
> > * Package name : tslib
> > Version : 1.24-1
> > Upstream contact : tslib@lists.infradead.org
> > * URL : http://tslib.org
> > * License : LGPL-2+, GPL-2+
> > * Vcs : https://github.com/merge/tslib-debian
> > Section : embedded
> >
> >
> > Changes since the last upload:
> >
> > tslib (1.24-1) unstable; urgency=low
> > .
> > * Update to tslib version 1.24
> > * debiann/rules: add empty dh_missing override
> > * debian: remove compat file and move to control
> > * debian/compat: update to v13
> >
> > Regards,
> >
> > --
> > Martin Kepplinger-Novakovic
>
> - d/changelog:
> - Version 1.23-1 has never been in Debian. Please merge the
> relevant
> entries to 1.24-1 OR mark 1.23-1 UNRELEASED.
> - SV-Bump to 4.7.2 has not been documented. Did you need to change
> anything?
> ( - d/changelog seems to focus on "what" has changed, not "why".
> The
> what is usually clear when looking at the diff, but not the "why".
> This
> makes reviewing harder.)
>
> - d/rules:
> - all those DEB_*_MAINT_* shouldn't be needed anymore, check if
> they
> can be removed; -O2 should never be set in d/rules, this break eg
> DEB_BUILD_OPTIONS=noopt,
> - why do you overrule_dh_missing? Guessing that you might have
> files
> not installed, they would go to d/not-installed.
exactly. Thanks for bringing this up. The scripts say "not installed"
for many library files but I couldn't reproduce that locally. lib so-
files are being installed it seems. How would you test this?
thank you for reviewing!
>
> - d/copyright
> - the year of your contributions could be updated.
>
> - d/*.install
> - instead of usr/lib/*/ you could write
> usr/lib/${DEB_HOST_MULTIARCH}/
Reply to: