Bug#1120466: RFS: xsnow/1:3.8.6-1 -- brings Christmas to your desktop
Control: tags -1 moreinfo
Hi Willem,
On Mon, 10 Nov 2025 13:02:02 +0100 Willem Vermin <wvermin@gmail.com>
wrote:
> * Package name : xsnow
> Version : 1:3.8.6-1
> Upstream contact : Willem Vermin <wvermin@gmail.com>
> * URL : https://sourceforge.net/projects/xsnow/
> * License : LGPL-2.1+, FSFULLR, GPL-3+, BSD-3-Clause, MIT-
CMU, HPND-sell-variant-and/or-NTP~disclaimer, MIT-open-group, FSFAP,
> xsnow (1:3.8.6-1) unstable; urgency=low
> .
> * New upstream release
> * Remove 'Donation' from upstream/metadata
> * Changed Standards Version to 4.7.2
> * Added salsa-ci.yml
> * Changed tests/test2.sh to accommodate slower systems
Should this have Closes: #1120037 ?
> * Added psmisc to tests/control
> * Added psmisc to control
>
Thanks for the updated package! The package has only minor things:
- (nitpick) d/patches is empty, delete it
- d/copyright seems incomplete, e.g debian/tests/test1.sh has an
undocumented copyright holder. (Rick Jansen) Rick is also not mentioned
in several files in src. Please add them.
Hint (as yours is not wrong, but could be optimized): In your
d/copyright you have a for debian, overlapping with the main section
Files: debian/tests/*
Copyright: 2024, Willem Vermin <wvermin@gmail.com>
License: GPL-3+
This all can be covered already by the "Files: *" section:
Files: *
Copyright: 2019-2024 Willem Vermin <wvermin@gmail.com>
License: GPL-3+
And for the missing copyright holder, it is also ok to just write:
Files: *
Copyright: 2019-2024 Willem Vermin <wvermin@gmail.com>
1984-2001 Rick Jansen
License: GPL-3+
Did you intentionally put the debian changelog under GPL, not GPL3+
like the rest of the package?
The copyright files needs reviewing, please remove the moreinfo tag
after this has been done, and this can be sponsored.
--
tobi
Reply to: