[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#1111080: RFS: python-pytooling/8.5.1-1 [ITP] -- Python Library for collection of useful data models, classes, decorators




On 14/08/25 20:00, Phil Wyett wrote:
Control: tags -1 +moreinfo

I am not a Debian Developer (DD) (and can never be, you could say I have been
DAM'ed) and have no ability to upload your package, sorry. This review is for
your information with no requirement to act upon it.

Aryan,

Review of upload: 2025-08-14 14:12

Test 1 (reproducibility): Information only, not a blocker

* Good

Test 2 (pbuilder build): Information only

* Good

Test 3 (pbuilder build --twice): Information only

* Good

Test 4 (sbuild): Information only

Lintian:

P: python-pytooling source: trailing-whitespace [debian/control:48]
N: 
N:   This file contains lines with trailing whitespace characters.
N:   
N:   Whilst often harmless and unsightly, such extra whitespaces can also cause
N:   tools to interpret the whitespace characters literally. The tool diff(1)
N:   does not like them, either. They are best avoided.
N:   
N:   Some of these problems can be hard to track down.
N:   
N:   Whitespace at the end of lines may be removed with the following:
N:   
N:    $ sed -i -e 's@[[:space:]]*$@@g' debian/control debian/changelog
N:   
N:   If you use Emacs, you can also use "M-x wh-cl" (whitespace-cleanup).
N:   
N:   However, if you wish to only remove trailing spaces and leave trailing
N:   tabs (eg. for Makefiles), you can use the following code snippet:
N:   
N:    $ sed -i -e 's@[ ]*$@@g' debian/rules
N:   
N:   To remove empty lines from the end of a file, you can use:
N:   
N:    $ sed -i -e :a -e '/^\n*$/{$d;N;};/\n$/ba' debian/rules
N: 
N:   Visibility: pedantic
N:   Show-Always: no
N:   Check: debian/trailing-whitespace
N:   Renamed from: file-contains-trailing-whitespace
N: 
N:
P: python-pytooling source: trailing-whitespace [debian/control:49]

Test 5 (ratt): Information only, not a blocker

Note: Possible false positives.

* Good

Test 6 (debian/watch): Information only

philwyett@ks-tarkin:~/build/python-pytooling-8.5.1$ uscan --dehs 
<dehs>
<package>python-pytooling</package>
<debian-uversion>8.5.1</debian-uversion>
<debian-mangled-uversion>8.5.1</debian-mangled-uversion>
<upstream-version>6.1.0</upstream-version>
<upstream-
url>https://pypi.debian.net/pyTooling/pyTooling-6.1.0.tar.gz</upstream-url>
<status>only older package available</status>
</dehs>

Test 7 (licenserecon): Information only

philwyett@ks-tarkin:~/build/python-pytooling-8.5.1$ lrc
en: Versions: licenserecon '7.0'  licensecheck '3.3.9-1'

Parsing Source Tree  ....
Reading d/copyright  ....
Running licensecheck ....

d/copyright      | licensecheck

Apache-2.0       | Apache            doc/Common/Licensing.rst
Apache-2.0       | CC-BY-4.0         doc/Doc-License.rst

Summary
=======

Looks very promising, but with a few issues you may wish to look at.

Tags
====

If a 'moreinfo' tag has been added to your RFS bug. You can remove the tag using
the line below at the top of a reply that is supplying information and/or
indicating a new upload.

Control: tags -1 -moreinfo

Regards

Phil

Thanks,

Fixed them in upload #3. Applied the licensing approach we took for verilog-parser, hope it works.

PyPi Debian Net isn't tracking this package correctly so informed the maintainer of this website about the same.

-- 
Regards,

Aryan Karamtoth
Matrix: @SpaciousCoder78:matrix.org
XMPP: SpaciousCoder78@xmpp.earth

GPG Fingerprint: 7A7D 9308 2BD1 9BAF A83B 7E34 FE90 07B8 ED64 0421

Attachment: OpenPGP_0xFE9007B8ED640421.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature


Reply to: