[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1110378: RFS: kafel/0~20231004-2 [ITP] -- seccomp-bpf language parser for nsjail



Hi Stephen,

You can use the '-f' switch with 'dput' to force upload a '-1' version.

Regards

Phil


On Sun, 2025-08-10 at 15:46 -0700, Stephen Crosby wrote:
> Thank you for the review, Phil. I have a question about the version number. In
> my changelog, I have now versions 0~20231004-1 and 0~20231004-2. You say "For
> a new package you only really need the first line" in the changelog. Does that
> mean I should remove 0~20231004-2 and reuse version 0~20231004-1? If I do
> that, when I build the package, it will produce files with the same version
> number as files that I have already uploaded. I had thought that would not be
> allowed. Is it allowed? And is that the expectation that I should rebuild and
> reupload version 0~20231004-1?
> 
> On Sat, Aug 9, 2025 at 10:35 PM Phil Wyett <philip.wyett@kathenas.org> wrote:
> > Control: tags -1 +moreinfo
> > 
> > I am not a Debian Developer (DD) (and can never be) and have no ability to
> > upload your package, sorry. This review is for your information with no
> > requirement to act upon it.
> > 
> > Stephen,
> > 
> > Review of upload: 2025-08-10 04:42
> > 
> > Test 1 (reproducibility): Information only, not a blocker
> > 
> > * Good
> > 
> > Test 2 (pbuilder build): Information only
> > 
> > * Good
> > 
> > Test 3 (pbuilder build --twice): Information only
> > 
> > * Good
> > 
> > Test 4 (sbuild): Information only
> > 
> > Lintian:
> > 
> > P: kafel source: trailing-whitespace [debian/rules:35]
> > N: 
> > N:   This file contains lines with trailing whitespace characters.
> > N:   
> > N:   Whilst often harmless and unsightly, such extra whitespaces can also
> > cause
> > N:   tools to interpret the whitespace characters literally. The tool
> > diff(1)
> > N:   does not like them, either. They are best avoided.
> > N:   
> > N:   Some of these problems can be hard to track down.
> > N:   
> > N:   Whitespace at the end of lines may be removed with the following:
> > N:   
> > N:    $ sed -i -e 's@[[:space:]]*$@@g' debian/control debian/changelog
> > N:   
> > N:   If you use Emacs, you can also use "M-x wh-cl" (whitespace-cleanup).
> > N:   
> > N:   However, if you wish to only remove trailing spaces and leave trailing
> > N:   tabs (eg. for Makefiles), you can use the following code snippet:
> > N:   
> > N:    $ sed -i -e 's@[ ]*$@@g' debian/rules
> > N:   
> > N:   To remove empty lines from the end of a file, you can use:
> > N:   
> > N:    $ sed -i -e :a -e '/^\n*$/{$d;N;};/\n$/ba' debian/rules
> > N: 
> > N:   Visibility: pedantic
> > N:   Show-Always: no
> > N:   Check: debian/trailing-whitespace
> > N:   Renamed from: file-contains-trailing-whitespace
> > 
> > Test 5 (ratt): Information only, not a blocker
> > 
> > Note: Possible false positives.
> > 
> > Test 6 (debian/watch): Information only
> > 
> > philwyett@ks-tarkin:~/build/kafel-0~20231004$ uscan --dehs 
> > <dehs>
> > Newest version of kafel on remote site is 20231004, local version is
> > 0~20231004
> >  => Newer package available from:
> >         => https://github.com/google/kafel.git refs/tags/20231004
> > Cloning into bare repository '../kafel-temporary.234349.git'...
> > remote: Enumerating objects: 106, done.
> > remote: Counting objects: 100% (106/106), done.
> > remote: Compressing objects: 100% (92/92), done.
> > remote: Total 106 (delta 21), reused 46 (delta 2), pack-reused 0 (from 0)
> > Receiving objects: 100% (106/106), 90.33 KiB | 3.23 MiB/s, done.
> > Resolving deltas: 100% (21/21), done.
> > Successfully renamed ../kafel-20231004.tar.xz to
> > ../kafel_20231004.orig.tar.xz.
> > <package>kafel</package>
> > <debian-uversion>0~20231004</debian-uversion>
> > <debian-mangled-uversion>0~20231004</debian-mangled-uversion>
> > <upstream-version>20231004</upstream-version>
> > <upstream-url>https://github.com/google/kafel.git
> > refs/tags/20231004</upstream-
> > url>
> > <status>newer package available</status>
> > <target>kafel_20231004.orig.tar.xz</target>
> > <target-path>../kafel_20231004.orig.tar.xz</target-path>
> > <messages>Successfully downloaded upstream package: 20231004
> > 
> > </messages>
> > </dehs>
> > 
> > Test 7 (licenserecon): Information only
> > 
> > * Good - See hint below in summary section.
> > 
> > Summary
> > =======
> > 
> > Test 4:
> > 
> > Some trailing white space you may wish to address.
> > 
> > Test 6:
> > 
> > You may wish to look at scanning for 'releases' in the 'debian/watch' file.
> > 
> > Test 7:
> > 
> > Whole project is Apache-2.0. Maybe you could consider shortening the
> > 'debian/copyright' to like below.
> > 
> > Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
> > Source: https://github.com/google/kafel
> > Upstream-Name: kafel
> > Upstream-Contact: https://github.com/google/kafel/issues
> > Files:
> >  *
> > Copyright: 2016-2025 Google
> > License: Apache-2.0
> > 
> > License: Apache-2.0
> >  Licensed under the Apache License, Version 2.0 (the "License");
> >  you may not use this file except in compliance with the License.
> >  You may obtain a copy of the License at
> >  .
> >     http://www.apache.org/licenses/LICENSE-2.0
> >  .
> >  Unless required by applicable law or agreed to in writing, software
> >  distributed under the License is distributed on an "AS IS" BASIS,
> >  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> >  See the License for the specific language governing permissions and
> >  limitations under the License.
> >  .
> >  On Debian systems, the complete text of the Apache License version 2
> >  can be found in /usr/share/common-licenses/Apache-2.0
> > 
> > Files: debian/*
> > Copyright: 2025 Stephen Crosby
> > License: Apache-2.0
> >  Licensed under the Apache License, Version 2.0 (the "License");
> >  you may not use this file except in compliance with the License.
> >  You may obtain a copy of the License at
> >  .
> >     http://www.apache.org/licenses/LICENSE-2.0
> >  .
> >  Unless required by applicable law or agreed to in writing, software
> >  distributed under the License is distributed on an "AS IS" BASIS,
> >  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> >  See the License for the specific language governing permissions and
> >  limitations under the License.
> >  .
> >  On Debian systems, the complete text of the Apache License version 2
> >  can be found in /usr/share/common-licenses/Apache-2.0
> > 
> > Additional
> > ==========
> > 
> > * New versions or new package into the Debian archive must be Debian version
> > '-
> > 1'.
> > 
> > * For a new package you only really need the first line in the
> > 'debian/changelog' that also closes the ITP bug.
> > 
> > I hope these suggestions assist you.
> > 
> > Tags
> > ====
> > 
> > If a 'moreinfo' tag has been added to your RFS bug. You can remove the tag
> > using
> > the line below at the top of a reply that is supplying information and/or
> > indicating a new upload.
> > 
> > Control: tags -1 -moreinfo
> > 
> > Regards
> > 
> > Phil
> > 

-- 

Blog: https://blog.kathenas.org

Buy me a coffee: https://buymeacoffee.com/kathenasorg

GPG Fingerprint: 70A0 AC45 AC77 9EFE 84F6 3AED 724A A9B5 2F02 4C8B

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: