Fabrice, I would suggest looking at the Python Team documentation and possibly discussing the issues on the python mailing list. Regards Phil On Sun, 2025-08-10 at 19:22 +0000, code@luigifab.fr wrote: > Hello, > > Thank you! > > > Test 3: ...local changes detected... yes it's intended, I'm updating one > file to identify the installation method when you are running the > program, example: > > fabrice@mario:~$ radexreader tail > python3-radexreader-deb 1.3.0 − python 3.13.5, pyusb 1.2.1-2, pyserial > 3.5 > ... > > > Test 4: ...uses-deprecated-python-stdlib... it's used only in the > "except" of the try/catch block > > > Test 6: I'm not sure what to do > > > Test Y: ...'Rules-Requires-Root: no' is no longer required... oh really? > ok, I'll have to remove it from my other packages as well > > > Le 10/08/2025 18:43, Phil Wyett a écrit : > > Control: tags -1 +moreinfo > > > > I am not a Debian Developer (DD) (and can never be) and have no ability > > to > > upload your package, sorry. This review is for your information with no > > requirement to act upon it. > > > > Fabrice, > > > > Review of upload: 2025-08-09 07:42 > > > > Test 1 (reproducibility): Information only, not a blocker > > > > * Good > > > > Test 2 (pbuilder build): Information only > > > > * Good > > > > Test 3 (pbuilder build --twice): Information only > > > > dpkg-source --after-build . > > dpkg-buildpackage: info: full upload (original source is included) > > dpkg-genchanges: info: including full source code in upload > > dpkg-buildpackage: info: source package python-radexreader > > dpkg-buildpackage: info: source version 1.3.0-1 > > dpkg-buildpackage: info: source distribution experimental > > dpkg-buildpackage: info: source changed by Fabrice Creuzot > > <code@luigifab.fr> > > dpkg-buildpackage: info: host architecture amd64 > > dpkg-source --before-build . > > debian/rules clean > > dh clean --with bash-completion --with python3 > > dh_clean > > dpkg-source -b . > > dpkg-source: info: using source format '3.0 (quilt)' > > dpkg-source: info: building python-radexreader using existing ./python- > > radexreader_1.3.0.orig.tar.gz > > dpkg-source: info: local changes detected, the modified files are: > > python-radexreader-1.3.0/src/radexreader-cli.py > > dpkg-source: hint: make sure the version in debian/changelog matches > > the > > unpacked source tree > > dpkg-source: hint: you can integrate the local changes with dpkg-source > > --commit > > dpkg-source: error: aborting due to unexpected upstream changes, see > > /tmp/python-radexreader_1.3.0-1.diff._HnvU7 > > dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit > > status 2 > > I: copying local configuration > > E: Failed autobuilding of package > > > > Test 4 (sbuild): Information only > > > > Lintian: > > > > I: python3-radexreader: spelling-error-in-description "allow to" "allow > > one to" > > N: > > N: Lintian found a spelling error in the package description. Lintian > > has a > > N: list of common misspellings that it looks for. It does not have a > > N: dictionary like a spelling checker does. It is particularly picky > > about > > N: spelling and capitalization in package descriptions since they're > > very > > N: visible to end users. > > N: > > N: Visibility: info > > N: Show-Always: no > > N: Check: fields/description > > N: > > N: > > I: radexreader: spelling-error-in-description "allow to" "allow one to" > > N: > > I: radexreader: typo-in-manual-page "allow to" "allow one to" > > [usr/share/man/man1/radexreader.1.gz:18] > > N: > > N: Lintian found a spelling error in a manual page. Lintian has a > > list of > > N: common misspellings that it looks for. It does not have a > > dictionary like > > N: a spelling checker does. > > N: > > N: If the string containing the spelling error is translated with the > > help of > > N: gettext (with the help of po4a, for example) or a similar tool, > > please fix > > N: the error in the translations as well as the English text to avoid > > making > > N: the translations fuzzy. With gettext, for example, this means you > > should > > N: also fix the spelling mistake in the corresponding msgids in the > > *.po > > N: files. > > N: > > N: Visibility: info > > N: Show-Always: no > > N: Check: documentation/manual > > N: Renamed from: spelling-error-in-manpage > > N: > > N: > > I: python-radexreader source: uses-deprecated-python-stdlib distutils > > (deprecated in Python 3.10, removed in Python 3.12) [src/setup.py:22] > > N: > > N: > > N: The Python library flagged by this tag has been formally marked as > > N: deprecated. > > N: > > N: Please prepare for this deprecation and migrate away from this > > Python > > N: library. > > N: > > N: See-Also: https://peps.python.org/pep-0594/#deprecated-modules > > N: > > N: Visibility: info > > N: Show-Always: no > > N: Check: languages/python/stdlib-deprecation > > > > Test 5 (ratt): Information only, not a blocker > > > > Note: Possible false positives. > > > > * Good > > > > Test 6 (debian/watch): Information only > > > > philwyett@ks-tarkin:~/build/python-radexreader-1.3.0$ uscan --dehs > > uscan warn: The directory name scripts doesn't match the requirement of > > --check-dirname-level=1 > > --check-dirname-regex=python\-radexreader(-.+)? . > > Set --check-dirname-level=0 to disable this sanity check feature., > > skipping > > <dehs> > > <package>python-radexreader</package> > > <debian-uversion>1.3.0</debian-uversion> > > <debian-mangled-uversion>1.3.0</debian-mangled-uversion> > > <upstream-version>1.3.0</upstream-version> > > <upstream- > > url> > > https://api.github.com/repos/luigifab/python-radexreader/tarball/refs/tags/v1.3.0 > > </upstream-url> > > <status>up to date</status> > > </dehs> > > > > Test 7 (licenserecon): Information only > > > > * Good > > > > Summary > > ======= > > > > Looking very promising. > > > > A few issues raised above that you may wish to look at. > > > > 'Rules-Requires-Root: no' is no longer required in 'debian/control'. > > The setting > > 'no' is now the default behaviour. You may wish to remove the line. > > > > Tags > > ==== > > > > If a 'moreinfo' tag has been added to your RFS bug. You can remove the > > tag using > > the line below at the top of a reply that is supplying information > > and/or > > indicating a new upload. > > > > Control: tags -1 -moreinfo > > > > Regards > > > > Phil -- Blog: https://blog.kathenas.org Buy me a coffee: https://buymeacoffee.com/kathenasorg GPG Fingerprint: 70A0 AC45 AC77 9EFE 84F6 3AED 724A A9B5 2F02 4C8B
Attachment:
signature.asc
Description: This is a digitally signed message part