[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1110692: RFS: parser/3.5.1-3 [QA] -- Parser 3, HTML-embedded scripting language



Control: tags -1 +confirmed

I am not a Debian Developer (DD) (and can never be) and have no ability to
upload your package, sorry. This review is for your information with no
requirement to act upon it.

Yavor,

Review of upload: 2025-08-10 05:57

Test 1 (reproducibility): Information only, not a blocker

* Good

Test 2 (pbuilder build): Information only

* Good

Test 3 (pbuilder build --twice): Information only

* Good

Test 4 (sbuild): Information only

Lintian:

Running lintian...
N:
I: parser source: override_dh_auto_test-does-not-check-DEB_BUILD_OPTIONS
[debian/rules:24]
N: 
N:   The debian/rules file for this package has an override_dh_auto_test target
N:   that does not appear to check DEB_BUILD_OPTIONS against nocheck.
N:   
N:   As this check is not automatically performed by debhelper(7), the
N:   specified testsuite is run regardless of another maintainer using the
N:   nocheck build option.
N:   
N:   Please add a check such as:
N:   
N:    override_dh_auto_test:
N:    ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
N:            ./run-upstream-testsuite
N:    endif
N:   
N:   Lintian will ignore comments and other lines such as:
N:   
N:    # Disabled
N:    : Disabled
N:    echo "Disabled"
N:    mkdir foo/
N:    ENV=var dh_auto_test -- ARG=value
N:   
N:   This check is not required in Debhelper compat level 13 or greater (see
N:   Bug#568897).
N: 
N:   Please refer to debian/rules and DEB_BUILD_OPTIONS (Section 4.9.1) in the
N:   Debian Policy Manual and
N:   https://wiki.debian.org/BuildProfileSpec#Registered_profile_names for
N:   details.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: debian/rules
N: 
N:
P: parser source: maintainer-manual-page [debian/parser3.1]
N: 
N:   The maintainer keeps a manual page in ./debian. Please forward the manual
N:   page upstream and ask them to include in their version control system, and
N:   in their next release.
N:   
N:   If the manual page was already forwarded or rejected, or the upstream is
N:   gone, please override the tag and annotate it with a suitable comment.
N: 
N:   Please refer to social contract item 2, Coordination with upstream
N:   developers (Section 3.1.4) in the Debian Developer's Reference, and
N:   Changes to the upstream sources (Section 4.3) in the Debian Policy Manual
N:   for details.
N: 
N:   Visibility: pedantic
N:   Show-Always: no
N:   Check: debian/manual-pages
N:   Renamed from: maintainer-manpage
N: 
N:
N: False positive; the file is under the University of Illinois Open Source
N: License.
O: parser source: license-problem-convert-utf-code
[src/lib/punycode/pa_convert_utf.c]
N: 
N:   The following file source files include material under a non-free license
N:   from Unicode Inc. Therefore, it is not possible to ship this in main or
N:   contrib.
N:   
N:   This license does not grant any permission to modify the files (thus
N:   failing DFSG#3). Moreover, the license grant seems to attempt to restrict
N:   use to "products supporting the Unicode Standard" (thus failing DFSG#6).
N:   
N:   In this case a solution is to use libicu and to remove this code by
N:   repacking.
N: 
N:   Please refer to Bug#823100 for details.
N: 
N:   Visibility: error
N:   Show-Always: no
N:   Check: cruft
N: 
N:
N: the entire rfc is not included, only the code points
O: parser source: license-problem-non-free-RFC [src/lib/punycode/pa_punycode.c]
N: 
N:   The given source file is licensed under the newer RFC license.
N:   
N:   The majority of IETF documents, such as RFCs, are not licensed under
N:   DFSG-free terms, and should thus not be included in Debian main.
N:   
N:   If this file is multi-licensed, please override the tag.
N: 
N:   Please refer to https://wiki.debian.org/NonFreeIETFDocuments for details.
N: 
N:   Visibility: error
N:   Show-Always: no
N:   Check: cruft
N: 
N:
N: the entire rfc is not included, only the code points
O: parser source: license-problem-non-free-RFC [src/lib/punycode/pa_punycode.h]

I: Lintian run was successful.

Test 5 (ratt): Information only, not a blocker

Note: Possible false positives.

* Good

Test 6 (debian/watch): Information only

* Good

Test 7 (licenserecon): Information only

philwyett@ks-tarkin:~/build/parser-3.5.1$ lrc
en: Versions: licenserecon '6.0'  licensecheck '3.3.9-1'

Parsing Source Tree  ....
Reading d/copyright  ....
Running licensecheck ....

d/copyright      | licensecheck

GPL-2+           | FSFULLR           aclocal.m4
GPL-2+           | FSFUL             configure
GPL-2+           | GPL-2+ with Libtool exception ltmain.sh
permissive and NTP| NTP               src/lib/gd/gifio.C
LGPL-2+ with Libtool exception| FSFULLR           src/lib/ltdl/aclocal.m4
LGPL-2+ with Libtool exception| X11               src/lib/ltdl/config/install-sh
LGPL-2+ with Libtool exception| GPL-2+ with Libtool exception
src/lib/ltdl/config/ltmain.sh
LGPL-2+ with Libtool exception| FSFUL             src/lib/ltdl/configure
LGPL-2+ with Libtool exception| LGPL-2+           src/lib/ltdl/configure.ac
LGPL-2+ with Libtool exception| LGPL-2+          
src/lib/ltdl/libltdl/lt__private.h
LGPL-2+ with Libtool exception| FSFULLR           src/lib/ltdl/m4/argz.m4
LGPL-2+ with Libtool exception| (FSFULLR and/or GPL-2+) with Libtool exception
src/lib/ltdl/m4/libtool.m4
LGPL-2+ with Libtool exception| FSFULLR           src/lib/ltdl/m4/ltdl.m4
LGPL-2+ with Libtool exception| FSFULLR           src/lib/ltdl/m4/lt~obsolete.m4
LGPL-2+ with Libtool exception| FSFULLR           src/lib/ltdl/m4/ltoptions.m4
LGPL-2+ with Libtool exception| FSFULLR           src/lib/ltdl/m4/ltsugar.m4
LGPL-2+ with Libtool exception| FSFULLR           src/lib/ltdl/m4/ltversion.m4
LGPL-2+ with Libtool exception| LGPL-2+           src/lib/ltdl/Makefile.am
Beerware-and-public-domain| Beerware and/or public-domain src/lib/md5/pa_md5c.c
University-of-Illinois-Open-Source-License| Unicode-strict   
src/lib/punycode/pa_convert_utf.c
University-of-Illinois-Open-Source-License| Unicode-strict   
src/lib/punycode/pa_convert_utf.h
LGPL-3+ or GPL-2+| LGPL              src/lib/punycode/pa_idna.c
LGPL-3+ or GPL-2+| LGPL              src/lib/punycode/pa_idna.h
LGPL-3+ or GPL-2+| LGPL              src/lib/punycode/pa_punycode.c
LGPL-3+ or GPL-2+| LGPL              src/lib/punycode/pa_punycode.h

Summary
=======

Looks good here.

Possible issue highlighted are only for information.

QA Upload. Tagging as 'confirmed'.

Tags
====

If a 'moreinfo' tag has been added to your RFS bug. You can remove the tag using
the line below at the top of a reply that is supplying information and/or
indicating a new upload.

Control: tags -1 -moreinfo

Regards

Phil

-- 

Blog: https://blog.kathenas.org

Buy me a coffee: https://buymeacoffee.com/kathenasorg

GPG Fingerprint: 70A0 AC45 AC77 9EFE 84F6 3AED 724A A9B5 2F02 4C8B

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: