[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1110158: RFS: robotraconteur-companion/0.4.2-3 [ITP] -- companion C++ library for robotraconteur



Control: tags -1 +moreinfo

I have no decision making athority within the Debian Project. You may reject
this review if you wish.

John,

Review of upload: 2025-08-02 01:57

Test 1 (reproducibility): Information only, not a blocker

Not being performed until bug below is fixed and accurate documentation written.

Bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1108550

Test 2 (pbuilder build): Information only

* Good

Test 3 (pbuilder build --twice): Information only

* Good

Test 4 (sbuild): Information only

* Good

Test 5 (ratt): Information only, not a blocker

Note: Possible false positives.

* Good

Test 6 (debian/watch): Information only

* Good

Test 7 (licenserecon): Information only

philwyett@ks-tarkin:~/build/robotraconteur-companion-0.4.2$ lrc
en: Versions: licenserecon '6.0'  licensecheck '3.3.9-1'

Parsing Source Tree  ....
Reading d/copyright  ....
Running licensecheck ....

d/copyright      | licensecheck

Apache           | Apache-2.0       
include/RobotRaconteurCompanion/Converters/EigenConverters.h
Apache           | Apache-2.0       
include/RobotRaconteurCompanion/InfoParser/yaml/yaml_parser_all.h
Apache           | Apache-2.0       
include/RobotRaconteurCompanion/StdRobDef/StdRobDefAll.h
Apache           | Apache-2.0       
include/RobotRaconteurCompanion/Util/AttributesUtil.h
Apache           | Apache-2.0       
include/RobotRaconteurCompanion/Util/DateTimeUtil.h
Apache           | Apache-2.0       
include/RobotRaconteurCompanion/Util/DeviceConnector.h
Apache           | Apache-2.0       
include/RobotRaconteurCompanion/Util/IdentifierUtil.h
Apache           | Apache-2.0       
include/RobotRaconteurCompanion/Util/ImageUtil.h
Apache           | Apache-2.0       
include/RobotRaconteurCompanion/Util/InfoFileLoader.h
Apache           | Apache-2.0       
include/RobotRaconteurCompanion/Util/LocalIdentifiersManager.h
Apache           | Apache-2.0       
include/RobotRaconteurCompanion/Util/SensorDataUtil.h
Apache           | Apache-2.0       
include/RobotRaconteurCompanion/Util/TaskGenerator.h
Apache           | Apache-2.0       
include/RobotRaconteurCompanion/Util/TestFixtures.h
Apache           | Apache-2.0       
include/RobotRaconteurCompanion/Util/UuidUtil.h
Apache           | Apache-2.0        LICENSE.txt
Apache           | Apache-2.0        robdef/LICENSE.txt
Apache           | BSD-3-clause      robdef/tools/urdf_to_robotinfo.py
Apache           | Apache-2.0        src/AttributesUtil.cpp
Apache           | Apache-2.0        src/DateTimeUtil.cpp
Apache           | Apache-2.0        src/EigenConverters.cpp
Apache           | Apache-2.0        src/IdentifierUtil.cpp
Apache           | Apache-2.0        src/InfoFileLoader.cpp

Summary
=======

Just an issue, 'Apache' not the correct 'Apache-2.0' is in the 'Files: *'
section of 'debian/copyright'.

Also the first commit was 2019 so shpuld be also reflected in the 'Files: *'
sectoin.

Tags
====

If a 'moreinfo' tag has been added to your RFS bug. You can remove the tag using
the line below at the top of a reply that is supplying information and/or
indicating a new upload.

Control: tags -1 -moreinfo

Regards

Phil

-- 

Blog: https://blog.kathenas.org

GPG Fingerprint: 70A0 AC45 AC77 9EFE 84F6 3AED 724A A9B5 2F02 4C8B

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: