[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1110157: RFS: robotraconteur/1.2.5-1 [ITP] -- communication framework for robotics and automation



Control: tags -1 +confirmed

I have no decision making athority within the Debian Project. You may reject
this review if you wish.

John,

Review of upload: 2025-08-03 05:57

Test 1 (reproducibility): Information only, not a blocker

Not being performed until bug below is fixed and accurate documentation written.

Bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1108550

Test 2 (pbuilder build): Information only

* Good

Test 3 (pbuilder build --twice): Information only

* Good

Test 4 (sbuild): Information only

* Good

Test 5 (ratt): Information only, not a blocker

Note: Possible false positives.

* Good

Test 6 (debian/watch): Information only

* Good

Test 7 (licenserecon): Information only

* Good

Summary
=======

Great bit of work and I bet for you a little learning in the ways of Debian
packaging.

Looks good. Tagging as 'confirmed'.

One thing to maybe edit before upload is in 'debian/copyright'. Your first
commit was in 2018, so I would make your entry in the 'Files: *' section as
below.

Files: *
Copyright: 2018-2025 John Wason <wason@wasontech.com>
License: Apache-2.0

Tags
====

If a 'moreinfo' tag has been added to your RFS bug. You can remove the tag using
the line below at the top of a reply that is supplying information and/or
indicating a new upload.

Control: tags -1 -moreinfo

Regards

Phil

-- 

Blog: https://blog.kathenas.org

GPG Fingerprint: 70A0 AC45 AC77 9EFE 84F6 3AED 724A A9B5 2F02 4C8B

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: