[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1110157: RFS: robotraconteur/1.2.5-1 [ITP] -- communication framework for robotics and automation



Control: tags -1 +moreinfo

I have no decision making athority within the Debian Project. You may reject
this review if you wish.

John,

Review of upload: 2025-08-02 17:27

Test 1 (reproducibility): Information only, not a blocker

Not being performed until bug below is fixed and accurate documentation written.

Bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1108550

Test 2 (pbuilder build): Information only

* Good

Test 3 (pbuilder build --twice): Information only

* Good

Test 4 (sbuild): Information only

Lintian:

I: robotraconteur source: patch-not-forwarded-upstream [debian/patches/0001-Add-
ROBOTRACONTEUR_SKIP_RPATH-cmake-option.patch]
N: 
N:   According to the DEP-3 headers, this patch has not been forwarded
N:   upstream.
N:   
N:   Please forward the patch and try to have it included in upstream's version
N:   control system. If the patch is not suitable for that, please mention
N:   not-needed in the Forwarded field of the patch header.
N: 
N:   Please refer to social contract item 2, Coordination with upstream
N:   developers (Section 3.1.4) in the Debian Developer's Reference, Changes to
N:   the upstream sources (Section 4.3) in the Debian Policy Manual, and
N:   Bug#755153 for details.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: debian/patches/dep3
N:   Renamed from: send-patch
N: 
N:
I: robotraconteur source: patch-not-forwarded-upstream [debian/patches/0002-
Cmake-package-files-only-with-BUILD_CORE.patch]
N:
I: robotraconteur source: patch-not-forwarded-upstream [debian/patches/0003-Fix-
spelling-errors.patch]

Test 5 (ratt): Information only, not a blocker

Note: Possible false positives.

* Good

Test 6 (debian/watch): Information only

* Good

Test 7 (licenserecon): Information only

* Good

Summary
=======

Looking great now. One thing left to do, modify the patches headers for DEP-3
compliance. You can find the link to relevant data at the link below.

https://dep-team.pages.debian.net/deps/dep3/

Tags
====

If a 'moreinfo' tag has been added to your RFS bug. You can remove the tag using
the line below at the top of a reply that is supplying information and/or
indicating a new upload.

Control: tags -1 -moreinfo

-- 

Blog: https://blog.kathenas.org

GPG Fingerprint: 70A0 AC45 AC77 9EFE 84F6 3AED 724A A9B5 2F02 4C8B

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: