[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1110157: RFS: robotraconteur/1.2.5-1 [ITP] -- communication framework for robotics and automation



Control: tags -1 -moreinfo

I have made the requested changes:

* I would have to update lots of other places so for now I am going to use patches rather than a new release.
* Examples added to the librobotraconteur-dev package.
* Copyright updated to cover the BSL-1.0 file.

The package has been pushed to mentors and salsa.

John

On 8/2/2025 6:15 AM, Phil Wyett wrote:
Control: tags -1 +moreinfo

I have no decision making athority within the Debian Project. You may reject
this review if you wish.

John,

Review of upload: 2025-08-02 01:57

Test 1 (reproducibility): Information only, not a blocker

Not being performed until bug below is fixed and accurate documentation written.

Bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1108550

Test 2 (pbuilder build): Information only

* Good

Test 3 (pbuilder build --twice): Information only

* Good

Test 4 (sbuild): Information only

Lintian:

I: robotraconteur source: patch-not-forwarded-upstream [debian/patches/0001-Add-
ROBOTRACONTEUR_SKIP_RPATH-cmake-option.patch]
N:
N:   According to the DEP-3 headers, this patch has not been forwarded
N:   upstream.
N:
N:   Please forward the patch and try to have it included in upstream's version
N:   control system. If the patch is not suitable for that, please mention
N:   not-needed in the Forwarded field of the patch header.
N:
N:   Please refer to social contract item 2, Coordination with upstream
N:   developers (Section 3.1.4) in the Debian Developer's Reference, Changes to
N:   the upstream sources (Section 4.3) in the Debian Policy Manual, and
N:   Bug#755153 for details.
N:
N:   Visibility: info
N:   Show-Always: no
N:   Check: debian/patches/dep3
N:   Renamed from: send-patch
N:
N:
I: robotraconteur source: patch-not-forwarded-upstream [debian/patches/0002-
Cmake-package-files-only-with-BUILD_CORE.patch]
N:
I: robotraconteur source: patch-not-forwarded-upstream [debian/patches/0003-Fix-
spelling-errors.patch]
N:
P: robotraconteur source: package-does-not-install-examples [examples/]
N:
N:   The original source tarball contains the specified examples directory.
N:   However, no examples are installed in any binary packages.
N:
N:   Please use dh_installexamples to install these to the most relevant
N:   package, for example by adding the directory name followed by a wildcard
N:   to a debian/pkgname.examples file.
N:
N:   Lintian looks for any directory called examples under /usr/share/doc in
N:   all binary packages.
N:
N:   Please refer to the dh_installexamples(1) manual page for details.
N:
N:   Visibility: pedantic
N:   Show-Always: no
N:   Check: examples
N:
N:   Screen: examples/in-tests
N:     Advocates: "Scott Kitterman" <debian@kitterman.com>
N:     Reason:
N:             Some sources like python-tomlkit trigger this tag for tests
because of files
N:             in ./tests/examples/. They are not examples for tomlkit, however.
They are
N:             examples of TOML files used in the tests.
N:
N:             Overall, the check is probably better off not looking in test
N:             directories.
N:
N:             Read more in Bug#1005184.

Test 5 (ratt): Information only, not a blocker

Note: Possible false positives.

* Good

Test 6 (debian/watch): Information only

* Good

Test 7 (licenserecon): Information only

philwyett@ks-tarkin:~/build/robotraconteur-1.2.5$ lrc
en: Versions: licenserecon '6.0'  licensecheck '3.3.9-1'

Parsing Source Tree  ....
Reading d/copyright  ....
Running licensecheck ....

d/copyright      | licensecheck

Apache-2.0       | BSL-1.0
examples/reynard_the_robot/cpp/service/json_body.hpp

Summary
=======

Test 4:

As upstream, you may wish to do another release, eliminate patches. Your choice
on that one.

The package has examples, are you intending to install them?

Test 7:

The file highlighted is BSL-1.0 and should be separately represented in
'debian/copyright'.

Tags
====

If a 'moreinfo' tag has been added to your RFS bug. You can remove the tag using
the line below at the top of a reply that is supplying information and/or
indicating a new upload.

Control: tags -1 -moreinfo

Regards

Phil



Reply to: