I have no decision making athority within the Debian Project. You may reject
this review if you wish.
Alexander,
Review of upload: 2025-08-01 08:12
Test 1 (reproducibility): Information only
Not being performed until bug below is fixed and accurate documentation written.
Bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1108550
Test 2 (pbuilder build): Information only
Good
Test 3 (pbuilder build --twice): Information only
Good
Test 4 (sbuild): Information only
Lintian:
W: dualword-rt source: build-depends-on-obsolete-package Build-Depends: pkg-
config => pkgconf
N:
N: The package build-depends on a package that has been superseded. If the
N: superseded package is part of an ORed group, it should not be the first
N: package in the group.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: fields/package-relations
N:
N:
W: dualword-rt source: no-debian-changes
N:
N: This non-native package makes no changes to the upstream sources in the
N: Debian-related files.
N:
N: Maybe a mistake was made when the upstream tarball was created, or maybe
N: this package is really a native package but was built non-native by
N: mistake.
N:
N: Debian packaging is sometimes maintained as part of upstream, but that is
N: not recommended as best practice. Please make this package native, if the
N: software is only for Debian. Otherwise, please remove the debian directory
N: from upstream releases and add it in the Debian packaging.
N:
N: Format 1.0 packages are subject to the restriction that the diff cannot
N: remove files from the debian directory. For Format 3.0 packages, the
N: debian directory is automatically purged during unpacking.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: files/artifact
N: Renamed from: empty-debian-diff
N:
N:
I: dualword-rt: extended-description-is-probably-too-short
N:
N: The extended description (the lines after the first line of the
N: "Description:" field) is only one or two lines long. The extended
N: description should provide a user with enough information to decide
N: whether they want to install this package, what it contains, and how it
N: compares to similar packages. One or two lines is normally not enough to
N: do this.
N:
N: Please refer to General guidelines for package descriptions (Section
N: 6.2.1) in the Debian Developer's Reference and The long description
N: (Section 6.2.3) in the Debian Developer's Reference for details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: fields/description
N:
N:
I: dualword-rt source: out-of-date-standards-version 4.5.1 (released 2020-11-17)
(current is 4.7.2)
N:
N: The source package refers to a Standards-Version older than the one that
N: was current at the time the package was created (according to the
N: timestamp of the latest debian/changelog entry). Please consider updating
N: the package to current Policy and setting this control field
N: appropriately.
N:
N: If the package is already compliant with the current standards, you don't
N: have to re-upload the package just to adjust the Standards-Version control
N: field. However, please remember to update this field next time you upload
N: the package.
N:
N: See /usr/share/doc/debian-policy/upgrading-checklist.txt.gz in the
N: debian-policy package for a summary of changes in newer versions of
N: Policy.
N:
N: Please refer to
N: https://www.debian.org/doc/debian-policy/upgrading-checklist.html for
N: details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: fields/standards-version
N:
N:
P: dualword-rt source: maintainer-manual-page [debian/dualword-rt.1]
N:
N: The maintainer keeps a manual page in ./debian. Please forward the manual
N: page upstream and ask them to include in their version control system, and
N: in their next release.
N:
N: If the manual page was already forwarded or rejected, or the upstream is
N: gone, please override the tag and annotate it with a suitable comment.
N:
N: Please refer to social contract item 2, Coordination with upstream
N: developers (Section 3.1.4) in the Debian Developer's Reference, and
N: Changes to the upstream sources (Section 4.3) in the Debian Policy Manual
N: for details.
N:
N: Visibility: pedantic
N: Show-Always: no
N: Check: debian/manual-pages
N: Renamed from: maintainer-manpage
N:
N:
P: dualword-rt source: trailing-whitespace [debian/changelog:3]
N:
N: This file contains lines with trailing whitespace characters.
N:
N: Whilst often harmless and unsightly, such extra whitespaces can also cause
N: tools to interpret the whitespace characters literally. The tool diff(1)
N: does not like them, either. They are best avoided.
N:
N: Some of these problems can be hard to track down.
N:
N: Whitespace at the end of lines may be removed with the following:
N:
N: $ sed -i -e 's@[[:space:]]*$@@g' debian/control debian/changelog
N:
N: If you use Emacs, you can also use "M-x wh-cl" (whitespace-cleanup).
N:
N: However, if you wish to only remove trailing spaces and leave trailing
N: tabs (eg. for Makefiles), you can use the following code snippet:
N:
N: $ sed -i -e 's@[ ]*$@@g' debian/rules
N:
N: To remove empty lines from the end of a file, you can use:
N:
N: $ sed -i -e :a -e '/^\n*$/{$d;N;};/\n$/ba' debian/rules
N:
N: Visibility: pedantic
N: Show-Always: no
N: Check: debian/trailing-whitespace
N: Renamed from: file-contains-trailing-whitespace
Test 5 (ratt): Information only
Good
Test 6 (debian/watch): Information only
Good
Test 7 (licenserecon): Information only
philwyett@ks-tarkin:~/build/dualword-rt-0.1.3$ lrc
en: Versions: licenserecon '6.0' licensecheck '3.3.9-1'
Parsing Source Tree ....
Reading d/copyright ....
Missing Files: Paragraph for debian/
Running licensecheck ....
d/copyright | licensecheck
GPL-3 | GPL-3+ src/app/DualwordRT.cpp
GPL-3 | GPL-3+ src/app/DualwordRT.h
GPL-3 | GPL-3+ src/app/Rnd.h
GPL-3 | GPL-3+ src/app/Time.h
GPL-3 | GPL-3+ src/global.h
GPL-3 | GPL-3+ src/gui/MainWindow.cpp
GPL-3 | GPL-3+ src/gui/MainWindow.h
GPL-3 | GPL-3+ src/gui/Scene.cpp
GPL-3 | GPL-3+ src/gui/Scene.h
GPL-3 | GPL-3+ src/gui/View.cpp
GPL-3 | GPL-3+ src/gui/View.h
GPL-3 | GPL-3+ src/main.cpp
Summary
=======
Thanks for making the initial changes. Above is a number of issues you may wish
to address.
Tags
====
If a 'moreinfo' tag has been added to your RFS bug. You can remove the tag using
the line below at the top of a reply that is supplying information and/or
indicating a new upload.
Control: tags -1 -moreinfo
Regards
Phil
--
Blog: https://blog.kathenas.org
GPG Fingerprint: 70A0 AC45 AC77 9EFE 84F6 3AED 724A A9B5 2F02 4C8B
Attachment:
signature.asc
Description: This is a digitally signed message part