|
>
From: Phil Wyett
> Sent: Monday, July 07, 2025 11:07 AM
> To: 1108730@bugs.debian.org
> Cc: 1108730-submitter@bugs.debian.org
> Subject: Bug#1108730: RFS: python-googlesearch/1.3.0-1 [ITP] -- Python library for scraping the Google search engine.
> Control: tags -1 +moreinfo
> Aryan, > Review of upload: 2025-07-07 04:27 > For information about the tests run, see: > Note: If test line removed, it indicates a test pass.
> Test 4 (sbuild): Information only > Lintian: > P: python-googlesearch source: trailing-whitespace [debian/changelog:3] > N: > N: This file contains lines with trailing whitespace characters. > N: > N: Whilst often harmless and unsightly, such extra whitespaces can also cause > N: tools to interpret the whitespace characters literally. The tool diff(1) > N: does not like them, either. They are best avoided. > N: > N: Some of these problems can be hard to track down. > N: > N: Whitespace at the end of lines may be removed with the following: > N: > N: $ sed -i -e 's@[[:space:]]*$@@g' debian/control debian/changelog > N: > N: If you use Emacs, you can also use "M-x wh-cl" (whitespace-cleanup). > N: > N: However, if you wish to only remove trailing spaces and leave trailing > N: tabs (eg. for Makefiles), you can use the following code snippet: > N: > N: $ sed -i -e 's@[ ]*$@@g' debian/rules > N: > N: To remove empty lines from the end of a file, you can use: > N: > N: $ sed -i -e :a -e '/^\n*$/{$d;N;};/\n$/ba' debian/rules > N: > N: Visibility: pedantic > N: Show-Always: no > N: Check: debian/trailing-whitespace > N: Renamed from: file-contains-trailing-whitespace > N: > N: > P: python-googlesearch source: trailing-whitespace [debian/control:28] > N: > P: python-googlesearch source: trailing-whitespace [debian/control:30] > N: > P: python-googlesearch source: trailing-whitespace [debian/rules:7] > N: > P: python-googlesearch source: trailing-whitespace [debian/rules:8] > Summary > ======= > Looking promising. A few lintian issues to be resolved and we can review again. > -- > Regards > Phil > -- > Donate to this Free/OSS and Debian contributor. > -- > GPG Fingerprint: 70A0 AC45 AC77 9EFE 84F6 3AED 724A A9B5 2F02 4C8B Hi Phil, thanks for taking your time reviewing my package. I've rebuilt the package following your test #4 that you mentioned on IRC.
I've added newlines at the end of debian/control and debian/rules to pass all lintian tests of sbuild.
Here's the final sbuild output:
+------------------------------------------------------------------------------+
| Summary Mon, 07 Jul 2025 07:20:35 +0000 |
+------------------------------------------------------------------------------+
Autopkgtest: no tests
Build Architecture: amd64
Build Type: full
Build-Space: 248
Build-Time: 5
Distribution: unstable
Host Architecture: amd64
Install-Time: 126
Job: /home/aryan/Documents/googlesearch deb/python-googlesearch_1.3.0-1.dsc
Lintian: pass
Machine Architecture: amd64
Package: python-googlesearch
Package-Time: 156
Source-Version: 1.3.0-1
Space: 248
Status: successful
Version: 1.3.0-1
--------------------------------------------------------------------------------
Finished at 2025-07-07T07:15:51Z
Build needed 00:02:36, 248k disk space
I also ran piuparts separately as mentioned in test #4 against sources.changes file and here's the output:
2m55.6s INFO: PASS: All tests.
2m55.6s INFO: piuparts run ends.
The updated package can be found here:
https://mentors.debian.net/package/python-googlesearch/
Thank you Phil.
Regards,
Aryan Karamtoth (IRC: SpaciousCoder78)
|