[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1107556: RFS: shotwell/0.32.13-1 -- digital photo organizer



Control: tags -1 +confirmed

Jorg,

Review of upload: 2025-06-09 11:42

For information about the tests run, see:

https://wiki.debian.org/PhilWyett/DebianMentoring

Test 4 (sbuild): Information only

Lintian:

Running lintian...
N:
W: shotwell: old-fsf-address-in-copyright-file
N: 
N:   The /usr/share/doc/*pkg*/copyright file refers to the old postal address
N:   of the Free Software Foundation (FSF). You should refer to
N:   https://www.gnu.org/licenses/ instead of a physical address, for example:
N:   
N:     You should have received a copy of the GNU General Public License
N:     along with this program.  If not, see https://www.gnu.org/licenses/.
N: 
N:   Visibility: warning
N:   Show-Always: no
N:   Check: debian/copyright
N: 
N:
W: shotwell-common: old-fsf-address-in-copyright-file
N:
I: shotwell: no-symbols-control-file usr/lib/x86_64-linux-gnu/libshotwell-
authenticator.so.0.32.13
N: 
N:   Although the package includes a shared library, the package does not have
N:   a symbols control file.
N:   
N:   dpkg can use symbols files in order to generate more accurate library
N:   dependencies for applications, based on the symbols from the library that
N:   are actually used by the application.
N: 
N:   Please refer to the dpkg-gensymbols(1) manual page and
N:   https://wiki.debian.org/UsingSymbolsFiles for details.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: debian/shlibs
N: 
N:
I: shotwell: no-symbols-control-file usr/lib/x86_64-linux-gnu/libshotwell-
plugin-common.so.0.32.13
N:
I: shotwell: no-symbols-control-file usr/lib/x86_64-linux-gnu/libshotwell-
plugin-dev-1.0.so.0.32.13
N:
I: shotwell source: out-of-date-standards-version 4.7.0.1 (released 2024-08-25)
(current is 4.7.2)
N: 
N:   The source package refers to a Standards-Version older than the one that
N:   was current at the time the package was created (according to the
N:   timestamp of the latest debian/changelog entry). Please consider updating
N:   the package to current Policy and setting this control field
N:   appropriately.
N:   
N:   If the package is already compliant with the current standards, you don't
N:   have to re-upload the package just to adjust the Standards-Version control
N:   field. However, please remember to update this field next time you upload
N:   the package.
N:   
N:   See /usr/share/doc/debian-policy/upgrading-checklist.txt.gz in the
N:   debian-policy package for a summary of changes in newer versions of
N:   Policy.
N: 
N:   Please refer to
N:   https://www.debian.org/doc/debian-policy/upgrading-checklist.html for
N:   details.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: fields/standards-version
N: 
N:
I: shotwell: typo-in-manual-page overriden overridden
[usr/share/man/man1/shotwell.1.gz:56]
N: 
N:   Lintian found a spelling error in a manual page. Lintian has a list of
N:   common misspellings that it looks for. It does not have a dictionary like
N:   a spelling checker does.
N:   
N:   If the string containing the spelling error is translated with the help of
N:   gettext (with the help of po4a, for example) or a similar tool, please fix
N:   the error in the translations as well as the English text to avoid making
N:   the translations fuzzy. With gettext, for example, this means you should
N:   also fix the spelling mistake in the corresponding msgids in the *.po
N:   files.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: documentation/manual
N:   Renamed from: spelling-error-in-manpage
N: 
N:
O: shotwell: link-to-shared-library-in-wrong-package usr/lib/x86_64-linux-
gnu/libshotwell-authenticator.so.0.32.13 [usr/lib/x86_64-linux-gnu/libshotwell-
authenticator.so]
N: 
N:   Although this package is not a "-dev" package, it installs a
N:   "libsomething.so" symbolic link referencing the corresponding shared
N:   library. When the link doesn't include the version number, it is used by
N:   the linker when other programs are built against this shared library.
N:   
N:   Shared libraries are supposed to place such symbolic links in their
N:   respective "-dev" packages, so it is a bug to include it with the main
N:   library package.
N:   
N:   However, if this is a small package which includes the runtime and the
N:   development libraries, this is not a bug. In the latter case, please
N:   override this warning.
N: 
N:   Please refer to Development files (Section 8.4) in the Debian Policy
N:   Manual for details.
N: 
N:   Visibility: warning
N:   Show-Always: no
N:   Check: libraries/shared/links
N:   Renamed from: non-dev-pkg-with-shlib-symlink
N: 
N:
O: shotwell: link-to-shared-library-in-wrong-package usr/lib/x86_64-linux-
gnu/libshotwell-plugin-common.so.0.32.13 [usr/lib/x86_64-linux-gnu/libshotwell-
plugin-common.so]
N:
O: shotwell: link-to-shared-library-in-wrong-package usr/lib/x86_64-linux-
gnu/libshotwell-plugin-dev-1.0.so.0.32.13 [usr/lib/x86_64-linux-gnu/libshotwell-
plugin-dev-1.0.so]
N:
O: shotwell: package-name-doesnt-match-sonames libshotwell-authenticator0
libshotwell-plugin-common0 libshotwell-plugin-dev-1.0-0
N: 
N:   The package name of a library package should usually reflect the soname of
N:   the included library. The package name can determined from the library
N:   file name with the following code snippet:
N:   
N:    $ objdump -p /path/to/libfoo-bar.so.1.2.3 | sed -n -
e's/^[[:space:]]*SONAME[[:space:]]*//p' | \
N:        sed -r -e's/([0-9])\.so\./\1-/; s/\.so(\.|$)//; y/_/-/; s/(.*)/\L&/'
N: 
N:   Visibility: warning
N:   Show-Always: no
N:   Check: libraries/shared/soname
N: 

E: Lintian run failed (policy violation)

Summary
=======

Package looks good.

Tagging as 'confirmed' with knowledge of 13/trixie inclusion.

I would like to see the 'Standards-Version' updated.

Other lintian can be reviewed later.

-- 

Regards

Phil

Donate: https://buymeacoffee.com/kathenasorg

--

"I play the game for the game’s own sake"

Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans

--

Internet Relay Chat (IRC): kathenas

Website: https://kathenas.org

Instagram: https://instagram.com/kathenasorg

Threads: https://www.threads.net/@kathenasorg

--




Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: