[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Issue with dcmtk migration



Hi Sébastien,

First of all, thank you for having promptly followed up with
mitigation to issues appearing in the Orthanc suite since dcmtk
upload!  I think I have identified the root cause of the problem
in orthanc autopkgtest to be resolved with the following logic,
which allows for the first few attempts to fail with non-zero
exit codes, without dropping off the script unconditionally:

-------8<--------------8<--------------8<--------------8<-------
--- a/debian/tests/run-test
+++ b/debian/tests/run-test
@@ -38,6 +38,7 @@ fi
 # Try for 15 times to find the system REST API of Orthanc up and running
 URL=http://localhost:8042/system
 tries=15
+set +e
 while true
 do
     STATUSCODE=$(curl --silent --output /dev/null --write-out "%{http_code}" ${URL})
@@ -46,6 +47,7 @@ do
     test "$tries" -le 0 && echo "Unable to initialize Orthanc" && exit 1
     sleep 1
 done
+set -e
 
 
 URL="http://localhost:8042/app/explorer.html";
-------8<--------------8<--------------8<--------------8<-------

I have verified the patch resolves the problem for your orthanc
package.  A similar approach will do the job for your package
orthanc-wsi, but I also noted the run-dicom-image-transcode-test
will also need to depend on curl to operate properly.

In hope this helps,
-- 
  .''`.  Étienne Mollier <emollier@debian.org>
 : :' :  pgp: 8f91 b227 c7d6 f2b1 948c  8236 793c f67e 8f0d 11da
 `. `'   sent from /dev/pts/2, please excuse my verbosity
   `-    on air: The Dear Hunter - The Bitter Suite VI- Abandon

Attachment: signature.asc
Description: PGP signature


Reply to: