Bug#1100914: RFS: composefs/1.0.8-1 [ITP] -- mechanism for stacking read-only filesystems
Hello Philip,
On Sun, Mar 30, 2025 at 01:51:19PM +0100, Phil Wyett wrote:
> Control: tags -1 +moreinfo
>
> Roland,
>
> Review of upload: 2025-03-23 11:11
>
> For information about the tests run, see:
>
> https://wiki.debian.org/PhilWyett/DebianMentoring
>
> Summary
> =======
>
> Roland, Looking promising.
Thank you for your review!
> In test we are seeing 'tests/test-lib.sh: line 40: capsh: command not found'.
> Could you have a look at this?
Indeed. I've added the necessary build-deps for the tools used in the tests.
> Builds are failing due to test timeout, see below. Would you have time to
> investigate this?
>
> Summary of Failures:
>
> 2/6 check-checksums TIMEOUT 31.55s killed by signal 9 SIGKILL
>
> Ok: 5
> Expected Fail: 0
> Fail: 0
> Unexpected Pass: 0
> Skipped: 0
> Timeout: 1
> dh_auto_test: error: cd obj-x86_64-linux-gnu && DEB_PYTHON_INSTALL_LAYOUT=deb
> LC_ALL=C.UTF-8 MESON_TESTTHREADS=8 meson test --verbose returned exit code 1
> make: *** [debian/rules:4: binary] Error 25
> dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
> --------------------------------------------------------------------------------
> Build finished at 2025-03-30T12:38:54Z
Interesting, I've never seen these timeouts before, but they've now randomly
started appearing on my i386 Salsa builds too. The tests are generating several
composefs images, running fsck on them, inspecting their contents, computing
checksums, fuzzing input data, etc. I've now figured out that meson runs all
tests in parallel, and applies a default timeout of 30 seconds (unless
overwritten in the check-random-fuse test). Apparently this can lead to random
timeouts depending on the load of the build machine. I've now disabled
parallelity for dh_auto_test, which seems to solve this problem.
Additionally, I found that fsck.erofs makes the checksum test somehow hang
forever on the i386 CI builds. I currently have no setup to reproduce this on my
own machine, but since fsck.erofs is an optional dependency, and the tests also
run without it, I've decided not to include erofs-utils as a build-dep for now.
I've pushed my changes to Salsa and uploaded a new version to mentors.
- Roland
--
Roland Hieber, Pengutronix e.K. | rhi@pengutronix.de |
Steuerwalder Str. 21 | https://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Reply to: