Control: tags -1 +moreinfo
Peter,
Review of upload: 2025-03-08 23:41
For information about the tests run, see:
https://wiki.debian.org/PhilWyett/DebianMentoring
Test 4 (sbuild): Information only
Not an issue as such, but I would not put an override on 'Standards-Version'.
Test 5 (ratt): Information only
Information only as this package is in the nextcloud team.
2025/03/09 08:20:49 FAILED: owncloud-client (see buildlogs/owncloud-
client_5.2.1.13040+dfsg-3.0.1)
Error:
[ 76%] Linking CXX executable ../bin/OwncloudPropagatorTest
cd /build/reproducible-path/owncloud-client-5.2.1.13040+dfsg/obj-x86_64-linux-
gnu/test && /usr/bin/cmake -E cmake_link_script
CMakeFiles/OwncloudPropagatorTest.dir/link.txt --verbose=1
/build/reproducible-path/owncloud-client-
5.2.1.13040+dfsg/test/testcredentialmanager.cpp: In member function ‘void
OCC::TestCredentialManager::testSetGet2()’:
/build/reproducible-path/owncloud-client-
5.2.1.13040+dfsg/test/testcredentialmanager.cpp:115:16: error: ‘class
QSignalSpy’ has no member named ‘deleteLater’
115 | s->deleteLater();
| ^~~~~~~~~~~
/build/reproducible-path/owncloud-client-
5.2.1.13040+dfsg/test/testcredentialmanager.cpp:134:20: error: ‘class
QSignalSpy’ has no member named ‘deleteLater’
134 | s->deleteLater();
| ^~~~~~~~~~~
[ 76%] Linking CXX executable ../bin/SyncFileItemTest
Summary
=======
Peter, Some minor things above you may wish to look at?
Additionally, I would remove the empty 'd/patches' directory.
Maybe you would wish to add Salsa CI?
--
Regards
Phil
Donate: https://buymeacoffee.com/kathenasorg
--
"I play the game for the game’s own sake"
Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans
--
Internet Relay Chat (IRC): kathenas
Website: https://kathenas.org
Instagram: https://instagram.com/kathenasorg
Threads: https://www.threads.net/@kathenasorg
--
Attachment:
signature.asc
Description: This is a digitally signed message part