[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1095268: marked as done (RFS: getdns/1.6.0-3.2 [NMU] [RC] -- modern asynchronous DNS API (stub resolver))

Your message dated Fri, 7 Feb 2025 22:18:00 +0100
with message-id <9a20be86-b922-4bba-ae1b-4144ee504468@debian.org>
and subject line Re: RFS: getdns/1.6.0-3.2 [NMU] [RC] -- modern asynchronous DNS API (stub resolver)
has caused the Debian Bug report #1095268,
regarding RFS: getdns/1.6.0-3.2 [NMU] [RC] -- modern asynchronous DNS API (stub resolver)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1095268: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1095268
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: sponsorship-requests
Severity: important
Control: block 1074989 by -1

Dear mentors,

I am looking for a sponsor for my proposed NMU to fix FTBFS of getdns:

 * Package name     : getdns
   Version          : 1.6.0-3.2
   Upstream contact : [fill in name and email of upstream]
 * URL              : https://getdnsapi.net/
 * License          : Public-Domain, Public-domain, Expat, CC-BY-3.0, BSD-3-clause, ISC
 * Vcs              : https://salsa.debian.org/dns-team/getdns
   Section          : libs

The source builds the following binary packages:

  libgetdns-dev - modern asynchronous DNS API (development)
  libgetdns10t64 - modern asynchronous DNS API (shared library)
  getdns-utils - modern asynchronous DNS API (utils)
  stubby - modern asynchronous DNS API (stub resolver)

To access further information about this package, please visit the following URL:

  https://mentors.debian.net/package/getdns/

Alternatively, you can download the package with 'dget' using this command:

  dget -x https://mentors.debian.net/debian/pool/main/g/getdns/getdns_1.6.0-3.2.dsc

Changes since the last upload:

 getdns (1.6.0-3.2) unstable; urgency=medium
 .
   * Non-maintainer upload.
 .
   [ Debian Janitor ]
   * Remove constraints unnecessary since buster (oldstable):
     + stubby: Drop versioned constraint on getdns-utils in Replaces.
     + stubby: Drop versioned constraint on getdns-utils in Breaks.
   * debian/copyright: use spaces rather than tabs to start continuation lines.
   * Bump debhelper from old 11 to 13.
     + debian/rules: Drop --fail-missing argument to dh_missing, which is now the
       default.
   * Set debhelper-compat version in Build-Depends.
   * Update standards version to 4.6.2, no changes needed.
 .
   [ Andrew Bower ]
   * Patch tests to fix FTBFS with gcc-14. (Closes: #1074989)

The current state of the packaging repo is behind the archive. The
following tag is suitable for fast-forward merging and brings the
archive up to date with the previous NMU (-3.1), Janitor commits (the
first two of which were already merged, the others, not) and my patch to
fix FTBFS:

https://salsa.debian.org/abower/getdns/-/tags/rfs%2F1.6.0-3.2%2Fv1

I have given the package a brief check with the fix but I am not
otherwise a user of this package.

The RC bug which this proposed NMU fixes was raised in July 2024 and my
merge request to fix it in December 2024.

Thanks!

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message --- 
I am sponsoring a NMU to fix this.
Please find the debdiff attached.
diff -Nru getdns-1.6.0/debian/changelog getdns-1.6.0/debian/changelog
--- getdns-1.6.0/debian/changelog	2024-02-28 18:05:25.000000000 +0100
+++ getdns-1.6.0/debian/changelog	2025-02-03 08:11:36.000000000 +0100
@@ -1,3 +1,23 @@
+getdns (1.6.0-3.2) unstable; urgency=medium
+
+  * Non-maintainer upload.
+
+  [ Debian Janitor ]
+  * Remove constraints unnecessary since buster (oldstable):
+    + stubby: Drop versioned constraint on getdns-utils in Replaces.
+    + stubby: Drop versioned constraint on getdns-utils in Breaks.
+  * debian/copyright: use spaces rather than tabs to start continuation lines.
+  * Bump debhelper from old 11 to 13.
+    + debian/rules: Drop --fail-missing argument to dh_missing, which is now the
+      default.
+  * Set debhelper-compat version in Build-Depends.
+  * Update standards version to 4.6.2, no changes needed.
+
+  [ Andrew Bower ]
+  * Patch tests to fix FTBFS with gcc-14. (Closes: #1074989)
+
+ -- Andrew Bower <andrew@bower.uk>  Mon, 03 Feb 2025 07:11:36 +0000
+
 getdns (1.6.0-3.1) unstable; urgency=medium
 
   * Non-maintainer upload.
diff -Nru getdns-1.6.0/debian/compat getdns-1.6.0/debian/compat
--- getdns-1.6.0/debian/compat	2022-07-31 13:12:47.000000000 +0200
+++ getdns-1.6.0/debian/compat	1970-01-01 01:00:00.000000000 +0100
@@ -1 +0,0 @@
-11
diff -Nru getdns-1.6.0/debian/control getdns-1.6.0/debian/control
--- getdns-1.6.0/debian/control	2024-02-28 18:05:24.000000000 +0100
+++ getdns-1.6.0/debian/control	2025-02-03 08:08:20.000000000 +0100
@@ -7,7 +7,7 @@
 Build-Depends: dpkg-dev (>= 1.22.5),
  check,
  cmake,
- debhelper (>= 11~),
+ debhelper-compat (= 13),
  libbsd-dev,
  libev-dev,
  libevent-dev,
@@ -18,7 +18,7 @@
  libuv1-dev,
  libyaml-dev,
  unbound-anchor,
-Standards-Version: 4.3.0
+Standards-Version: 4.6.2
 Rules-Requires-Root: no
 Section: libs
 Homepage: https://getdnsapi.net/
@@ -32,6 +32,7 @@
  libgetdns10t64 (= ${binary:Version}),
  ${misc:Depends},
  ${shlibs:Depends},
+Multi-Arch: same
 Description: modern asynchronous DNS API (development)
  getdns is a modern asynchronous DNS API.  It implements DNS entry
  points from a design developed and vetted by application developers,
@@ -93,10 +94,6 @@
  libgetdns10t64 (= ${binary:Version}),
  ${misc:Depends},
  ${shlibs:Depends},
-Breaks:
- getdns-utils (<< 1.2.1-1~),
-Replaces:
- getdns-utils (<< 1.2.1-1~),
 Description: modern asynchronous DNS API (stub resolver)
  getdns is a modern asynchronous DNS API.  It implements DNS entry
  points from a design developed and vetted by application developers,
diff -Nru getdns-1.6.0/debian/copyright getdns-1.6.0/debian/copyright
--- getdns-1.6.0/debian/copyright	2022-07-31 13:12:47.000000000 +0200
+++ getdns-1.6.0/debian/copyright	2025-02-03 08:08:20.000000000 +0100
@@ -4,7 +4,7 @@
 
 Files: *
 Copyright: 2013, 2015 Verisign, Inc.
-	   2001-2017 NLnet Labs
+           2001-2017 NLnet Labs
            and other contributors
 License: BSD-3-clause
 
diff -Nru getdns-1.6.0/debian/patches/0006-Fix-incorrect-assertion.patch getdns-1.6.0/debian/patches/0006-Fix-incorrect-assertion.patch
--- getdns-1.6.0/debian/patches/0006-Fix-incorrect-assertion.patch	1970-01-01 01:00:00.000000000 +0100
+++ getdns-1.6.0/debian/patches/0006-Fix-incorrect-assertion.patch	2025-02-03 08:09:42.000000000 +0100
@@ -0,0 +1,23 @@
+Description: Fix incorrectly-written assertion breaking builds with gcc-14.
+ An assertion in test code was written incorrectly in a way that would always
+ succeed. This patch was independently developed to fix the Debian build but
+ the bug is also fixed as part of a larger patch fixing compiler warnings
+ upstream and is present in v1.7.0~rc.1 onwards. Importing the latest
+ upstream release will obviate the need for this patch.
+Author: Andrew Bower <andrew@bower.uk>
+Bug-Debian: https://bugs.debian.org/1074989
+Forwarded: not-needed
+Applied-Upstream: https://github.com/getdnsapi/getdns/commit/df2997d9b762d705d5f7add338e460686c9bd88f
+Last-Update: 2024-12-10
+
+--- getdns-1.6.0.orig/src/test/check_getdns_dict_set_bindata.h
++++ getdns-1.6.0/src/test/check_getdns_dict_set_bindata.h
+@@ -112,7 +112,7 @@
+       ASSERT_RC(getdns_dict_get_bindata(this_dict, "bindata", &retrieved_bindata),
+         GETDNS_RETURN_GOOD, "Return code from getdns_dict_get_bindata()");
+ 
+-      ck_assert_msg(retrieved_bindata->size, second_bindata.size,
++      ck_assert_msg(retrieved_bindata->size == second_bindata.size,
+         "Expected retrieved bindata size == %d, got: %d",
+         second_bindata.size, retrieved_bindata->size);
+ 
diff -Nru getdns-1.6.0/debian/patches/series getdns-1.6.0/debian/patches/series
--- getdns-1.6.0/debian/patches/series	2022-07-31 13:12:47.000000000 +0200
+++ getdns-1.6.0/debian/patches/series	2025-02-03 08:09:42.000000000 +0100
@@ -3,3 +3,4 @@
 0003-Fix-install-path-for-cmake-build-since-we-use-GNUIns.patch
 0004-Fix-stubby.yml-install-path-for-debian.patch
 0005-Fix-FindLibidn2-cmake.patch
+0006-Fix-incorrect-assertion.patch
diff -Nru getdns-1.6.0/debian/rules getdns-1.6.0/debian/rules
--- getdns-1.6.0/debian/rules	2022-07-31 13:12:47.000000000 +0200
+++ getdns-1.6.0/debian/rules	2025-02-03 08:08:20.000000000 +0100
@@ -24,7 +24,7 @@
 	dh_install -X.la
 
 override_dh_missing:
-	dh_missing -X.la --fail-missing
+	dh_missing -X.la
 
 override_dh_auto_test:
 	# remote tests fail when there's no connectivity or the connectivity is restrained

--- End Message ---
Reply to: