Bug#1094425: RFS: emacs-jsonrpc/1.0.25-1 [ITP] -- Emacs JSON-RPC library

[Phil Wyett <philip.wyett@kathenas.org>]

Control: tags -1 +confirmed

Xiyue,

Preamble...

Thank you for taking the time to prepare this package and your contribution to
the Debian project.

This review is offered to help package contributors to Debian mentors improve
their packages (where needed) prior to possible sponsorship into Debian by a
Debian Developer.


Review...

1. Build:

  * pbuilder [1]: Good
 
  * sbuild [2]: Good


2. Lintian [3]: Good


3. Licenses [4]: Good


4. Watch file [uscan --force-download]: Good, plus information

philwyett@ks-tarkin:~/Development/builder/debian/emacs-jsonrpc-1.0.25$ uscan --
force-download 
uscan warn: Possible OpenPGP signature found at:
   https://elpa.gnu.org/packages/jsonrpc-1.0.25.tar.sig
 * Add opts=pgpsigurlmangle=s/$/.sig/ or opts=pgpmode=auto to debian/watch
 * Add debian/upstream/signing-key.asc.
 See uscan(1) for more details
Successfully repacked ../jsonrpc-1.0.25.tar as ../emacs-
jsonrpc_1.0.25.orig.tar.xz.


5. Build Twice (build source after successful build) [1]: Good


6. Reproducible builds [5]: Good

Note: This test does not block sponsorship and is for information only at this
time. It is good if a package passes this test.


7. Tail of the ratt (architecture dependant packages only) [6]: Good

Note: This test does not block sponsorship and is for information only at this
time. It is good if a package passes this test.

philwyett@ks-tarkin:~/Development/builder/debian$ ratt --dist=trixie emacs-
jsonrpc_1.0.25-1_amd64.changes 
2025/01/28 06:48:41 Loading changes file "emacs-jsonrpc_1.0.25-1_amd64.changes"
2025/01/28 06:48:41  - 1 binary packages: elpa-jsonrpc
2025/01/28 06:48:41 Corresponding .debs (will be injected when building):
2025/01/28 06:48:41     elpa-jsonrpc_1.0.25-1_all.deb
2025/01/28 06:48:41 Figuring out reverse build dependencies using dose-ceve(1).
This might take a while
2025/01/28 06:48:59 Found 0 reverse build dependencies
2025/01/28 06:48:59 Setting -sbuild_dist=unstable (from .changes file)
2025/01/28 06:48:59 Build results:


8. Install [No previous installs]: Good


9. Upgrade [Over previous installs if any]: N/A


Summary...

Xiyue, Looks good. I will wait for you to complete your testing and file RFS
and we shall go from there mate.


Please try the below on your packages...

[1] pbuilder:

  * Command for 1.: sudo pbuilder build <PACKAGE>.dsc
  * Command for 5.: sudo pbuilder build --twice <PACKAGE>.dsc
  * Document: https://wiki.ubuntu.com/PbuilderHowto.
  * Document: https://wiki.debian.org/PbuilderTricks


[2] sbuild:

  * Command: sbuild -d unstable <PACKAGE>.dsc
  * Document: https://wiki.debian.org/sbuild


[3] lintian:

  * Command: lintian --display-info --verbose --fail-on error --info --pedantic
--show-overrides (*.dsc, *.changes, *.buildinfo). Each can throw up different
results, so be thorough.
  * Document: https://wiki.debian.org/Lintian


[4] lrc:

  * Command: lrc
  * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon

  Note: Please report false positives as bug reports against 'licenserecon'