Bug#1093846: RFS: dh-sysuser/1.6.0 [RC] -- alternantive debhelper addon to create system users

[Phil Wyett <philip.wyett@kathenas.org>]

Control: tags -1 +confirmed

Lorenzo

Preamble...

Thank you for taking the time to prepare this package and your contribution to
the Debian project.

This review is offered to help package contributors to Debian mentors improve
their packages (where needed) prior to possible sponsorship into Debian by a
Debian Developer.


Review...

1. Build:

  * pbuilder [1]: Good
 
  * sbuild [2]: Good


2. Lintian [3]: Good


3. Licenses [4]: Good


4. Watch file [uscan --force-download]: N/A


5. Build Twice (build source after successful build) [1]: Good


6. Reproducible builds [5]: Good

Note: This test does not block sponsorship and is for information only at this
time. It is good if a package passes this test.


7. Tail of the ratt (architecture dependant packages only) [6]: Information

Note: This test does not block sponsorship and is for information only at this
time. It is good if a package passes this test.

philwyett@ks-tarkin:~/Development/builder/debian$ ratt --dist=trixie -include
'^(runit)$' dh-sysuser_1.6.0_amd64.changes 
2025/01/24 03:23:29 Loading changes file "dh-sysuser_1.6.0_amd64.changes"
2025/01/24 03:23:29  - 2 binary packages: dh-sysuser sysuser-helper
2025/01/24 03:23:29 Corresponding .debs (will be injected when building):
2025/01/24 03:23:29     dh-sysuser_1.6.0_all.deb
2025/01/24 03:23:29     sysuser-helper_1.6.0_all.deb
2025/01/24 03:23:30 Figuring out reverse build dependencies using dose-ceve(1).
This might take a while
2025/01/24 03:24:05 Found 1 reverse build dependencies
2025/01/24 03:24:05 Based on the supplied include filter, will only build 1
reverse build dependencies
2025/01/24 03:24:05 Setting -sbuild_dist=unstable (from .changes file)
2025/01/24 03:24:05 Building package 1 of 1: runit 
2025/01/24 03:24:23 building runit failed: exit status 3
2025/01/24 03:24:23 1 packages failed the first pass; you can rerun ratt only
for them passing the option -include '^(runit)$'
2025/01/24 03:24:23 Build results:
2025/01/24 03:24:23 FAILED: runit (see buildlogs/runit_2.1.2-60)

buildlogs/runit_2.1.2-60 shows:

(I)Dose_applications: Solving...
output-version: 1.2
native-architecture: amd64
report:
 -
  package: sbuild-build-depends-main-dummy
  version: 0.invalid.0
  architecture: amd64
  status: broken
  reasons:
   -
    missing:
     pkg:
      package: sbuild-build-depends-main-dummy
      version: 0.invalid.0
      architecture: amd64
      unsat-dependency: dh-buildinfo:amd64 (>= 0.11+nmu1) | dh-buildinfo:amd64
(>= 0.11+nmu1)
 
background-packages: 71794
foreground-packages: 1
total-packages: 71795
broken-packages: 1

We have bugs:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1090770
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1092549

For information only. Is it time for a 'runit' release. :-)


8. Install [No previous installs]: Good


9. Upgrade [Over previous installs if any]: Good


Summary...

I believe 'dh-sysuser' is ready for review/possible sponsorship. Could a Debian
Developer (DD) with available free time, please review this package and upload
if you feel it is ready.


Please try the below on your packages...

[1] pbuilder:

  * Command for 1.: sudo pbuilder build <PACKAGE>.dsc
  * Command for 5.: sudo pbuilder build --twice <PACKAGE>.dsc
  * Document: https://wiki.ubuntu.com/PbuilderHowto.
  * Document: https://wiki.debian.org/PbuilderTricks


[2] sbuild:

  * Command: sbuild -d unstable <PACKAGE>.dsc
  * Document: https://wiki.debian.org/sbuild


[3] lintian:

  * Command: lintian --display-info --verbose --fail-on error --info --pedantic
--show-overrides (*.dsc, *.changes, *.buildinfo). Each can throw up different
results, so be thorough.
  * Document: https://wiki.debian.org/Lintian


[4] lrc:

  * Command: lrc
  * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon

  Note: Please report false positives as bug reports against 'licenserecon'