Bug#1089633: RFS: adminerevo/4.8.4-1 [ITP] -- Web-based database administration tool
Control: tags -1 +confirmed
Alexandre,
Preamble...
Thank you for taking the time to prepare this package and your contribution to
the Debian project.
This review is offered to help package submitters to Debian mentors inorder to
improve their packages prior to possible sponsorship into Debian. There is no
obligation on behalf of the submitter to make any alterations based upon
information provided in the review.
Review...
1. Build:
* pbuilder [1]: Good
* sbuild [2]: Good
2. Lintian [3]: Information only
Running lintian...
N:
I: adminerevo: package-contains-documentation-outside-usr-share-doc
[usr/share/adminerevo/plugins/drivers/readme.txt]
N:
N: This package ships a documentation file outside /usr/share/doc
N: Documentation files are normally installed inside /usr/share/doc.
N:
N: If this file doesn't describe the contents or purpose of the directory it
N: is in, please consider moving this file to /usr/share/doc/ or maybe even
N: removing it. If this file does describe the contents or purpose of the
N: directory it is in, please add a lintian override.
N:
N: Visibility: info
N: Show-Always: no
N: Check: documentation
N:
N: Screen: python/egg/metadata
N: Advocates: "Scott Kitterman" <debian@kitterman.com>
N: Reason: The folders XXX.dist-info/ and XXX.egg-info/ hold metadata for
N: Python modules. Those files are not documentation even though
N: some of their names carry the .txt file extension.
N:
N: Python modules can be both public and private.
N:
N: Read more in
N:
https://www.python.org/dev/peps/pep-0427/#the-dist-info-directory,
N: https://www.python.org/dev/peps/pep-0376/#id16,
N: https://www.python.org/dev/peps/pep-0610/,
N: https://www.python.org/dev/peps/pep-0639/,
N:
https://setuptools.pypa.io/en/latest/deprecated/python_eggs.html,
N: and Bug#1003913.
N:
N:
I: adminerevo: package-contains-empty-directory
[usr/share/adminerevo/designs/hydra/]
N:
N: This package installs an empty directory. This might be intentional but
N: it's normally a mistake. If it is intentional, add a Lintian override.
N:
N: If a package ships with or installs empty directories, you can remove them
N: in debian/rules by calling:
N:
N: $ find path/to/base/dir -type d -empty -delete
N:
N: Visibility: info
N: Show-Always: no
N: Check: files/empty-directories
N:
N:
I: adminerevo: package-contains-empty-directory
[usr/share/adminerevo/designs/pepa-linha-dark/]
N:
N: composer actually not used for building
O: adminerevo source: composer-package-without-pkg-php-tools-builddep
[composer.json]
N:
N: The package contains a composer.json file but doesn't build-depend on
N: pkg-php-tools.
N:
N: pkg-php-tools is the recommended tool for building PHP Composer packages.
N: For more information, install it and read the included README.Composer
Reply to: