Bug#1085943: RFS: qatzip -- Compression Library accelerated by Intel® QuickAssist Technology

["Colin King (gmail)" <colin.i.king@gmail.com>]

Hi Philip,

Thanks for this review. I'd like to keep to the two last lines in the 
debian changelog as an intentional aide-mémoire to remind me to ensure 
the spelling mistake patch gets landed in the upstream project and also 
get the upstream project to handle build cleaning before the next 
release. I handle quite a few packages and keeping track of these 
packaging details requires me to note what needs doing between each 
upload and upstream fixes before the next release occurs.

Colin

On 12/11/2024 16:46, Phil Wyett wrote:
> Control: tags -1 -moreinfo
> Control: tags -1 +confirmed
>
> Hi Colin,
>
> Preamble...
>
> Thank you for taking the time to prepare this package and your contribution
> to the Debian project.
>
> The review below is for assistance. This review is offered to help package
> submitters to Debian mentors inorder to improve their packages prior to
> possible sponsorship into Debian. There is no obligation on behalf of the
> submitter to make any alterations based upon information provided in the
> review.
>
> Review...
>
> 1. Build:
>
>    * pbuilder [1]: Good
>    * sbuild [2]: Good
>
> 2. Lintian [3]: Good
>
> 3. Licenses [4]: Good
>
> 4. Watch file [uscan --force-download]: Good
>
> 5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good
>
> 6. Reproducible builds [5]: Good
>
> 7. Install [No previous installs]: Good
>
> 8. Upgrade [Over previous installs if any]: N/A
>
> Summary...
>
> Colin, looks good to me. I would suggest removing the last two lines of you
> 'debian/changelog' entry. They are not needed for the initial release, just
> the first line is enough.
>
> I would encourage importing the package into Salsa, but that I leave as your
> decision.
>
> I believe qatzip is ready for review/possible sponsorship. Could a Debian
> Developer (DD) with available free time, please review this package and
> upload if you feel it is ready and appropriate for the distribution.
>
> Regards
>
> Phil
>
> [1] pbuilder:
>
>    * Command: sudo pbuilder build <PACKAGE>.dsc
>    * Document: https://wiki.ubuntu.com/PbuilderHowto.
>    * Document: https://wiki.debian.org/PbuilderTricks
>
> [2] sbuild:
>
>    * Command: sbuild <PACKAGE>.dsc
>    * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000002
>    * Document: https://wiki.debian.org/sbuild
>
> [3] lintian:
>
>    * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc,
> *.changes, *.buildinfo). Each can throw up different results, so be thorough.
>    * Document: https://wiki.debian.org/Lintian
>
> [4] lrc:
>
>    * Command: lrc
>    * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon
>
> [5] reprotest
>
>    * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-
> build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
>    * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
>    * Document: https://wiki.debian.org/ReproducibleBuilds/
>    * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method