Re: Bug#1083052: RFS: vimium/2.1.2-1 [ITP] -- keyboard-based navigation and control

To: 1083052@bugs.debian.org
Cc: debian-mentors@lists.debian.org, 1083052-submitter@bugs.debian.org
Subject: Re: Bug#1083052: RFS: vimium/2.1.2-1 [ITP] -- keyboard-based navigation and control
From: Soren Stoutner <soren@debian.org>
Date: Tue, 15 Oct 2024 16:10:04 -0700
Message-id: <[🔎] 1971637.XJWnPltQ1b@soren-desktop>
In-reply-to: <[🔎] O12FLS.OZA1PHOQA0PO3@posteo.de>
References: <6IUMKS.6XR5NVTE5U77@posteo.de> <[🔎] 6602301.Jmbp9rjdMR@soren-desktop> <[🔎] O12FLS.OZA1PHOQA0PO3@posteo.de>

Andreas,

On Tuesday, October 15, 2024 2:22:36 PM MST Andreas Altergott wrote:

> The package has been set up on salsa.debian.org. Vcs-Git and

> Vcs-Browser have been updated to the correct URL.

> A new build has been uploaded to mentors.debian.net.

This package is in really good shape. There are just a few things I think ought to be addressed before I sponsor it.

There are a number of lintian Info tags about files it thinks are documentation. My sense is that most or all of these are false positives. If so, please add lintian overrides for them.

I: webext-vimium-chromium: package-contains-documentation-outside-usr-share-doc [usr/share/chromium/extensions/vimium/pages/action.html]

N: This package ships a documentation file outside /usr/share/doc

N: Documentation files are normally installed inside /usr/share/doc.

N: If this file doesn't describe the contents or purpose of the directory it

N: is in, please consider moving this file to /usr/share/doc/ or maybe even

N: removing it. If this file does describe the contents or purpose of the

N: directory it is in, please add a lintian override.

N: Visibility: info

N: Show-Always: no

N: Check: documentation

N: Screen: python/egg/metadata

N: Advocates: "Scott Kitterman" <debian@kitterman.com>

N: Reason: The folders XXX.dist-info/ and XXX.egg-info/ hold metadata for

N: Python modules. Those files are not documentation even though

N: some of their names carry the .txt file extension.

N: Python modules can be both public and private.

N: Read more in

N: https://www.python.org/dev/peps/pep-0427/#the-dist-info-directory,

N: https://www.python.org/dev/peps/pep-0376/#id16,

N: https://www.python.org/dev/peps/pep-0610/,

N: https://www.python.org/dev/peps/pep-0639/,

N: https://setuptools.pypa.io/en/latest/deprecated/python_eggs.html,

N: and Bug#1003913.

I: webext-vimium-chromium: package-contains-documentation-outside-usr-share-doc [usr/share/chromium/extensions/vimium/pages/blank.html]

I: webext-vimium-chromium: package-contains-documentation-outside-usr-share-doc [usr/share/chromium/extensions/vimium/pages/completion_engines.html]

I: webext-vimium-chromium: package-contains-documentation-outside-usr-share-doc [usr/share/chromium/extensions/vimium/pages/exclusions.html]

I: webext-vimium-chromium: package-contains-documentation-outside-usr-share-doc [usr/share/chromium/extensions/vimium/pages/help_dialog.html]

I: webext-vimium-chromium: package-contains-documentation-outside-usr-share-doc [usr/share/chromium/extensions/vimium/pages/hud.html]

I: webext-vimium-chromium: package-contains-documentation-outside-usr-share-doc [usr/share/chromium/extensions/vimium/pages/options.html]

I: webext-vimium-chromium: package-contains-documentation-outside-usr-share-doc [usr/share/chromium/extensions/vimium/pages/reload.html]

I: webext-vimium-chromium: package-contains-documentation-outside-usr-share-doc [usr/share/chromium/extensions/vimium/pages/vomnibar.html]

I: webext-vimium-chromium: package-contains-documentation-outside-usr-share-doc [usr/share/chromium/extensions/vimium/resources/tlds.txt]

I: webext-vimium-firefox: package-contains-documentation-outside-usr-share-doc [usr/share/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-13a3a9e97384}/{d7742d87-e61d-4b78-b8a1-b469842139fa}/pages/action.html]

Your patches do not indicate a forwarded status. See the following two examples for how you can do this:

https://salsa.debian.org/qt-kde-team/qt/qtwebengine/-/blob/master/debian/patches/armhf-no-thumb.patch?ref_type=heads

https://salsa.debian.org/qt-kde-team/qt/qtwebengine/-/blob/master/debian/patches/mips64el-crashpad.patch?ref_type=heads

In debian/copyright, what is often called the MIT license should be referred to as Expat.

"There are many versions of the MIT license. Please use Expat instead, when it matches.”

https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/

https://www.debian.org/legal/licenses/mit

https://www.gnu.org/licenses/license-list.en.html#Expat

I noticed that upstream is licensed under Expat and you have licensed debian/* under GPL-3+. It is perfectly acceptable if you desire to do so. But if you haven’t already considered it, most people choose to license debian/* under the same license that upstream uses, so that if, in the future, there is any advantage to upstream anything in debian/*, there are no license restrictions to doing so.

Let me know when you have resolved the items above.

Soren

Soren Stoutner

soren@debian.org

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply to:

Follow-Ups:
- Re: Bug#1083052: RFS: vimium/2.1.2-1 [ITP] -- keyboard-based navigation and control
  - From: Soren Stoutner <soren@debian.org>

References:
- Re: Bug#1083052: RFS: vimium/2.1.2-1 [ITP] -- keyboard-based navigation and control
  - From: Soren Stoutner <soren@debian.org>
- Bug#1083052: RFS: vimium/2.1.2-1 [ITP] -- keyboard-based navigation and control
  - From: Andreas Altergott <andreas82@posteo.de>

Prev by Date: Bug#1083052: RFS: vimium/2.1.2-1 [ITP] -- keyboard-based navigation and control
Next by Date: Re: Bug#1083052: RFS: vimium/2.1.2-1 [ITP] -- keyboard-based navigation and control
Previous by thread: Bug#1083052: RFS: vimium/2.1.2-1 [ITP] -- keyboard-based navigation and control
Next by thread: Re: Bug#1083052: RFS: vimium/2.1.2-1 [ITP] -- keyboard-based navigation and control
Index(es):
- Date
- Thread