Bug#1084869: RFS: keepass2-plugin-keepassrpc/2.0.2+dfsg-1 [RFP] -- RPC plugin for KeePass 2 Password manager
Control: tags -1 -moreinfo
Thanks for the review.
Mentioned elements should be fixed with the latest upload to mentors.
Concerning the d/watch, it should not be used to create the orig.tar, but only
to check for new versions. See debian/README.source. The reference for the
orig.tar should be taken from pristine-tar branch of the repo.
Regards
Fabien Steinmetz
Le jeudi 10 octobre 2024 11:01:57 CEST, vous avez écrit :
> Control: tags -1 +moreinfo
>
> Fab,
>
> Preamble...
>
> Thank you for taking the time to prepare this package and your contribution
> to the Debian project.
>
> The review below is for assistance. This review is offered to help package
> submitters to Debian mentors inorder to improve their packages prior to
> possible sponsorship into Debian. There is no obligation on behalf of the
> submitter to make any alterations based upon information provided in the
> review.
>
> Review...
>
> 1. Build:
>
> * pbuilder [1]: Good
> * sbuild [2]: Good
>
> 2. Lintian [3]: Issue
>
> Running lintian...
> N:
> E: keepass2-plugin-keepassrpc changes: unreleased-changes
> N:
> N: The distribution in the Changes field copied from debian/changelog
> N: indicates that this package was not intended to be released yet.
> N:
> N: Please refer to Bug#542747 for details.
> N:
> N: Visibility: error
> N: Show-Always: no
> N: Check: fields/distribution
> N:
> N:
> I: keepass2-plugin-keepassrpc source: out-of-date-standards-version 4.6.2
> (released 2022-12-17) (current is 4.7.0)
> N:
> N: The source package refers to a Standards-Version older than the one
> that N: was current at the time the package was created (according to the
> N: timestamp of the latest debian/changelog entry). Please consider
> updating
> N: the package to current Policy and setting this control field
> N: appropriately.
> N:
> N: If the package is already compliant with the current standards, you
> don't
> N: have to re-upload the package just to adjust the Standards-Version
> control
> N: field. However, please remember to update this field next time you
> upload
> N: the package.
> N:
> N: See /usr/share/doc/debian-policy/upgrading-checklist.txt.gz in the
> N: debian-policy package for a summary of changes in newer versions of
> N: Policy.
> N:
> N: Please refer to
> N: https://www.debian.org/doc/debian-policy/upgrading-checklist.html for
> N: details.
> N:
> N: Visibility: info
> N: Show-Always: no
> N: Check: fields/standards-version
> N:
>
> E: Lintian run failed (runtime error)
>
> 3. Licenses [4]: Issue
>
> While I am OK with SPDX naming, it would be up to a DD who sponsors to
> decide what they would be wanting.
>
> The one below needs to be corrected.
>
> LGPL-3.0-or-later| LGPL-2.1+
> Jayrock/src/Jayrock.Json/Json/Conversion/Converters/ControlExporter.cs
>
> 4. Watch file [uscan --force-download]: Warnings
>
> philwyett@ks-tarkin:~/Development/builder/debian/mentoring/keepass2-plugin-
> keepassrpc-2.0.2+dfsg$ uscan --force-download
> uscan warn: No files matched excluded pattern as the last matching glob:
> Jayrock/samples/TidyJson/obj
> uscan warn: No files matched excluded pattern as the last matching glob:
> Jayrock/samples/TidyJson/bin
> Successfully repacked ../keepass2-plugin-keepassrpc-2.0.2.tar.xz as
> ./keepass2-plugin-keepassrpc_2.0.2+dfsg.orig.tar.xz, deleting 312 files from
> it.
>
> 5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good
>
> 6. Reproducible builds [5]: Good
>
> 7. Install [No previous installs]: Not performed at this time
>
> 8. Upgrade [Over previous installs if any]: N/A
>
> Additional...
>
> A. The 'd/changelog' for a new package needs only one line, see below. It
> declares an initial release into Debian and closed the ITP of RFP bug.
>
> * Initial release. (Closes: #928777)
>
> Summary...
>
> I believe keepass2-plugin-keepassrpc is not yet ready for sponsorship at
> this time. Could the contributor rectify one of more of the raised issues.
>
> Once updated to your satisfaction and a new upload done, please remove the
> 'moreinfo' tag on the Request For Sponsorship (RFS) bug report.
>
> Regards
>
> Phil
>
> [1] pbuilder:
>
> * Command: sudo pbuilder build <PACKAGE>.dsc
> * Document: https://wiki.ubuntu.com/PbuilderHowto.
> * Document: https://wiki.debian.org/PbuilderTricks
>
> [2] sbuild:
>
> * Command: sbuild <PACKAGE>.dsc
> * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000002
> * Document: https://wiki.debian.org/sbuild
>
> [3] lintian:
>
> * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc,
> *.changes, *.buildinfo). Each can throw up different results, so be
> thorough. * Document: https://wiki.debian.org/Lintian
>
> [4] lrc:
>
> * Command: lrc
> * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon
>
> [5] reprotest
>
> * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1
> --auto- build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
> * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
> * Document: https://wiki.debian.org/ReproducibleBuilds/
> * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method
Reply to: