[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1084920: RFS: caspar/20240818-1 -- Makefile snippets for centralized configuration management and typesetting



On Sat, 2024-10-12 at 14:30 +0200, Joost van Baal-Ilić wrote:
> Hi Phil,
> 
> On Sat, Oct 12, 2024 at 11:32:48AM +0100, Phil Wyett wrote:
> > On Sat, 2024-10-12 at 08:01 +0200, Joost van Baal-Ilić wrote:
> > > Hi again Phil,
> > > 
> > > Thanks a lot for this awesome analysis.  I'll prepare another
> > > caspar/20240818-1, likely today.  (It'll likely feature some lintian overrides,
> > > next to some "real" fixes.)
> > > 
> > > BTW, you do not check on the results of "make clean", do you?  There was some
> > > discussion a couple of months ago on wether we should strive to make that work
> > > as intended in all our packages; iirc such effort was basically given up.  For
> > > caspar it's still on my todo list; I believe "make clean" currently is broken
> > > there.
> > > 
> > > Bye,
> > > 
> > > Joost
> > > 
> > > 
> > 
> > <big snip>
> > 
> > Hi Joost,
> > 
> > To answer your question both tests 5 and 6 in my review set of tests do
> > multi-build and trigger dh_clean / dh_auto_clean which invokes the packages
> > own clean in 90% of cases (got the 90% stat from the dh_auto_clean manpage).
> > 
> > Your packages passed both, so all good.
> 
> 
> joostvb@agni:~/lo...n/caspar/caspar-20240818% debuild -uc -us
> [stuff, ok]
> 
> joostvb@agni:~/lo...n/caspar/caspar-20240818% debuild -uc -us
> [...]
> dpkg-source: info: local changes detected, the modified files are:
>  caspar-20240818/configure
> dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/caspar_20240818-1.diff.CPUJEC
> 
> So I think it's not good enough (to my taste) here yet... (Debian feels this is not a really
> important problem, I believe.)
> 
> Bye,
> 
> Joost
> 

Joost,

I shall wait for your next submission and we will test again.

Regards

Phil

-- 

"I play the game for the game’s own sake"

Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans

--

Buy Me A Coffee: https://buymeacoffee.com/kathenasorg

Internet Relay Chat (IRC): kathenas

Matrix: #kathenas:matrix.org

Website: https://kathenas.org

Instagram: https://instagram.com/kathenasorg/

Threads: https://www.threads.net/@kathenasorg

--






Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: