Bug#1084920: RFS: caspar/20240818-1 -- Makefile snippets for centralized configuration management and typesetting
Hi again Phil,
tl;dr: fixed some stuff, will publish a new caspar/20240818-1 likely today.
On Sat, Oct 12, 2024 at 08:01:24AM +0200, Joost van Baal-Ilić wrote:
>
> Thanks a lot for this awesome analysis. I'll prepare another
> caspar/20240818-1, likely today. (It'll likely feature some lintian overrides,
> next to some "real" fixes.)
>
> BTW, you do not check on the results of "make clean", do you? There was some
> discussion a couple of months ago on wether we should strive to make that work
> as intended in all our packages; iirc such effort was basically given up. For
> caspar it's still on my todo list; I believe "make clean" currently is broken
> there.
>
> Bye,
>
> Joost
>
> On Sat, Oct 12, 2024 at 03:54:59AM +0100, Phil Wyett wrote:
> > Joost,
> >
> > Preamble...
> >
> > Thank you for taking the time to prepare this package and your contribution
> > to the Debian project.
> >
> > The review below is for assistance. This review is offered to help package
> > submitters to Debian mentors inorder to improve their packages prior to
> > possible sponsorship into Debian. There is no obligation on behalf of the
> > submitter to make any alterations based upon information provided in the
> > review.
> >
> > Review...
> >
> > 1. Build:
> >
> > * pbuilder [1]: Good
> > * sbuild [2]: Good
> >
> > 2. Lintian [3]: Issue
> >
> > Running lintian...
> > N:
> > I: caspar: conflicts-with-version caspar-doc (<< 20091115-1)
> > N:
<snip>
> > N:
> > N: Check: fields/package-relations
Fixed.
> > I: caspar source: debian-watch-uses-insecure-uri http://mdcc.cx/pub/caspar/
> > [debian/watch:3]
> > N:
> > N: The watch file uses an unencrypted transport protocol for the URI such
<snip>
> > N: Check: debian/watch
Enabling httpS @ mdcc.cx is on my TODO-list. I choose not to add a lintian-override
for this, so that I keep being reminded.
> > I: caspar source: no-dh-sequencer [debian/rules]
> > N:
> > N: This package does not use the dh sequencer in debian/rules.
> > N:
> > N: While maintainers may use a variety of build systems, this one is by far
> > N: the most popular.
> > N:
> > N: Maintainers are strongly encouraged to use the dh sequencer in new
> > N: packages and convert existing ones when appropriate.
> > N:
> > N: Visibility: info
> > N: Show-Always: no
> > N: Check: debian/rules/dh-sequencer
This is a tricky one. I'll think about it.
> > I: caspar source: out-of-date-standards-version 3.9.8 (released 2016-04-06)
> > (current is 4.7.0)
> > N:
> > N: The source package refers to a Standards-Version older than the one that
> > N: was current at the time the package was created (according to the
> > N: timestamp of the latest debian/changelog entry). Please consider
> > updating
> > N: the package to current Policy and setting this control field
> > N: appropriately.
> > N:
> > N: If the package is already compliant with the current standards, you
> > don't
> > N: have to re-upload the package just to adjust the Standards-Version
> > control
> > N: field. However, please remember to update this field next time you
> > upload
> > N: the package.
> > N:
> > N: See /usr/share/doc/debian-policy/upgrading-checklist.txt.gz in the
> > N: debian-policy package for a summary of changes in newer versions of
> > N: Policy.
> > N:
> > N: Please refer to
> > N: https://www.debian.org/doc/debian-policy/upgrading-checklist.html for
> > N: details.
> > N:
> > N: Visibility: info
> > N: Show-Always: no
> > N: Check: fields/standards-version
Will get to it.
> > I: caspar: spare-manual-page [usr/share/man/man1/csp_helper.1.gz]
> > N:
> > N: Each manual page in /usr/share/man should have a reason to be there.
> > This
> > N: manual page does not appear to have a valid reason to be shipped.
> > N:
> > N: For manual pages in sections 1 and 8, an executable (or a link to one)
> > N: should exist. This check currently considers all installation packages
> > N: created by the same sources, as long as they are present.
> > N:
> > N: Please refer to Manual pages (Section 12.1) in the Debian Policy Manual
> > N: and Bug#583125 for details.
> > N:
> > N: Visibility: info
> > N: Show-Always: no
> > N: Check: documentation/manual
> > N: Renamed from: manpage-without-executable
Likely a bug in lintian, will investigate.
> > I: caspar: typo-in-manual-page commiting committing
> > [usr/share/man/man7/caspar.7.gz:94]
> > N:
<snip>
Fixed upstream in git. This fix will enter Debian later (will likely take at
least a couple of months).
> > I: caspar source: vcs-field-uses-insecure-uri Git
> > http://git.mdcc.cx/caspar.git/
> > N:
<snip>
> > N:
Will be fixed together with debian-watch-uses-insecure-uri .
> > I: Lintian run was successful.
> >
> > 3. Licenses [4]: Issue
> >
> > philwyett@ks-tarkin:~/Development/builder/debian/mentoring/caspar-20240818$
> > lrc
> > en: Versions: recon 2.0 check 3.3.9-1
> >
> > Parsing Source Tree ....
> > Reading d/copyright ....
> > Missing Files: Paragraph for debian/
> > Running licensecheck ....
> >
> > d/copyright | licensecheck
> >
> > GPL-3+ | GPL bootstrap
> > GPL-3+ | GPL doc/include.zmm
> > GPL-3+ | GPL doc/Makefile.am
> > GPL-3+ | GPL doc/Makefile.in
> > GPL-3+ | FSFAP INSTALL
> > GPL-3+ | GPL Makefile.am
> > GPL-3+ | GPL Makefile.in
> > GPL-3+ | GPL setversion
> >
> > Hint: In some files, replacing 'GNU GPL' with 'GNU GENERAL PUBLIC LICENSE
> > Version 3 or later' will fix the issue.
I'll think about what to do with this issue.
> >
<snip 3 more tests, passed with "Good">
> > 7. Install [No previous installs]: Not performed at this time.
> > 8. Upgrade [Over previous installs if any]: Not performed at this time.
> >
> > Summary...
> >
> > I believe <casper is not yet ready for sponsorship at this time. Could the
> > contributor rectify one of more of the raised issues.
> >
> > Once updated to your satisfaction and a new upload done, please remove the
> > 'moreinfo' tag on the Request For Sponsorship (RFS) bug report.
> >
> > Regards
> >
> > Phil
> >
> > [1] pbuilder:
> >
> > * Command: sudo pbuilder build <PACKAGE>.dsc
> > * Document: https://wiki.ubuntu.com/PbuilderHowto.
> > * Document: https://wiki.debian.org/PbuilderTricks
> >
> > [2] sbuild:
> >
> > * Command: sbuild <PACKAGE>.dsc
> > * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000002
> > * Document: https://wiki.debian.org/sbuild
> >
> > [3] lintian:
> >
> > * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc,
> > *.changes, *.buildinfo). Each can throw up different results, so be thorough.
> > * Document: https://wiki.debian.org/Lintian
> >
> > [4] lrc:
> >
> > * Command: lrc
> > * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon
> >
> > [5] reprotest
> >
> > * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-
> > build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
> > * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
> > * Document: https://wiki.debian.org/ReproducibleBuilds/
> > * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method
> >
> > --
> > "I play the game for the game’s own sake"
> >
> > Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans
> >
> > --
> >
> > Buy Me A Coffee: https://buymeacoffee.com/kathenasorg
> > Internet Relay Chat (IRC): kathenas
> > Matrix: #kathenas:matrix.org
> > Website: https://kathenas.org
> > Instagram: https://instagram.com/kathenasorg/
> > Threads: https://www.threads.net/@kathenasorg
Thanks again!
Bye,
Joost
Reply to: