Manuel, Updated review. Preamble... Thank you for taking the time to prepare this package and your contribution to the Debian project. The review below is for assistance. This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review. Review... 1. Build: * pbuilder [1]: Good * sbuild [2]: Good 2. Lintian [3]: Good 3. Licenses [4]: Issue, possibility of false positives philwyett@ks-tarkin:~/Development/builder/debian/mentoring/ventoy-1.0.99$ lrc en: Versions: recon 1.18 check 3.3.9-1 Parsing Source Tree .... Reading copyright .... Running licensecheck .... d/copyright | licensecheck GPL-3+ | GPL-2+ Ventoy2Disk/Lib/exfat/src/libexfat/byteorder.h GPL-3+ | GPL-2+ Ventoy2Disk/Lib/exfat/src/libexfat/cluster.c GPL-3+ | GPL-2+ Ventoy2Disk/Lib/exfat/src/libexfat/compiler.h GPL-3+ | GPL-2+ Ventoy2Disk/Lib/exfat/src/libexfat/exfatfs.h GPL-3+ | GPL-2+ Ventoy2Disk/Lib/exfat/src/libexfat/exfat.h GPL-3+ | GPL-2+ Ventoy2Disk/Lib/exfat/src/libexfat/io.c GPL-3+ | GPL-2+ Ventoy2Disk/Lib/exfat/src/libexfat/lookup.c GPL-3+ | GPL-2+ Ventoy2Disk/Lib/exfat/src/libexfat/mount.c GPL-3+ | GPL-2+ Ventoy2Disk/Lib/exfat/src/libexfat/node.c GPL-3+ | GPL-2+ Ventoy2Disk/Lib/exfat/src/libexfat/platform.h GPL-3+ | GPL-2+ Ventoy2Disk/Lib/exfat/src/libexfat/repair.c GPL-3+ | GPL-2+ Ventoy2Disk/Lib/exfat/src/libexfat/time.c GPL-3+ | GPL-2+ Ventoy2Disk/Lib/exfat/src/libexfat/utf.c GPL-3+ | GPL-2+ Ventoy2Disk/Lib/exfat/src/libexfat/utils.c GPL-3+ | GPL-2+ Ventoy2Disk/Lib/exfat/src/mkfs/cbm.c GPL-3+ | GPL-2+ Ventoy2Disk/Lib/exfat/src/mkfs/cbm.h GPL-3+ | GPL-2+ Ventoy2Disk/Lib/exfat/src/mkfs/fat.c GPL-3+ | GPL-2+ Ventoy2Disk/Lib/exfat/src/mkfs/fat.h GPL-3+ | GPL-2+ Ventoy2Disk/Lib/exfat/src/mkfs/mkexfat.c GPL-3+ | GPL-2+ Ventoy2Disk/Lib/exfat/src/mkfs/mkexfat.h GPL-3+ | GPL-2+ Ventoy2Disk/Lib/exfat/src/mkfs/mkexfat_main.c GPL-3+ | GPL-2+ Ventoy2Disk/Lib/exfat/src/mkfs/rootdir.c GPL-3+ | GPL-2+ Ventoy2Disk/Lib/exfat/src/mkfs/rootdir.h GPL-3+ | GPL-2+ Ventoy2Disk/Lib/exfat/src/mkfs/uct.c GPL-3+ | GPL-2+ Ventoy2Disk/Lib/exfat/src/mkfs/uctc.c GPL-3+ | GPL-2+ Ventoy2Disk/Lib/exfat/src/mkfs/uctc.h GPL-3+ | GPL-2+ Ventoy2Disk/Lib/exfat/src/mkfs/uct.h GPL-3+ | GPL-2+ Ventoy2Disk/Lib/exfat/src/mkfs/vbr.c GPL-3+ | GPL-2+ Ventoy2Disk/Lib/exfat/src/mkfs/vbr.h GPL-3+ | GPL-2+ Ventoy2Disk/Lib/fat_io_lib/fat_access.c GPL-3+ | GPL-2+ Ventoy2Disk/Lib/fat_io_lib/fat_cache.c GPL-3+ | GPL-2+ Ventoy2Disk/Lib/fat_io_lib/fat_filelib.c GPL-3+ | GPL-2+ Ventoy2Disk/Lib/fat_io_lib/fat_format.c GPL-3+ | GPL-2+ Ventoy2Disk/Lib/fat_io_lib/fat_misc.c GPL-3+ | GPL-2+ Ventoy2Disk/Lib/fat_io_lib/fat_string.c GPL-3+ | GPL-2+ Ventoy2Disk/Lib/fat_io_lib/fat_table.c GPL-3+ | GPL-2+ Ventoy2Disk/Lib/fat_io_lib/fat_write.c GPL-3+ | Expat Ventoy2Disk/Lib/libhttp/include/civetweb.c GPL-3+ | Expat Ventoy2Disk/Lib/libhttp/include/civetweb.h GPL-3+ | Expat Ventoy2Disk/Lib/libhttp/include/handle_form.inl GPL-3+ | public-domain Ventoy2Disk/Lib/xz- embedded/linux/lib/xz/xz_dec_syms.c GPL-3+ | public-domain Ventoy2Disk/Lib/xz- embedded/linux/lib/xz/xz_dec_test.c Tip: The 'debian' directory section should be that alone, no files or folders from other parts of the package. Just makes this cleaner. 4. Watch file [uscan --force-download]: Good 5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good 6. Reproducible builds [5]: Good 7. Install [No previous installs]: Good 8. Upgrade [Over previous installs if any]: N/A Summary... I believe ventoy is not yet ready for sponsorship at this time. Could the contributor rectify one of more of the rasied issues. Once updated to your satisfaction and a new upload done, please remove the 'moreinfo' tag on the Request For Sponsorship (RFS) bug report. Regards Phil [1] pbuilder: * Command: sudo pbuilder build <PACKAGE>.dsc * Document: https://wiki.ubuntu.com/PbuilderHowto. * Document: https://wiki.debian.org/PbuilderTricks [2] sbuild: * Command: sbuild <PACKAGE>.dsc * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000002 * Document: https://wiki.debian.org/sbuild [3] lintian: * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough. * Document: https://wiki.debian.org/Lintian [4] lrc: * Command: lrc * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon [5] reprotest * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto- build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004 * Document: https://wiki.debian.org/ReproducibleBuilds/ * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method -- "I play the game for the game’s own sake" Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans -- Buy Me A Coffee: https://buymeacoffee.com/kathenasorg Internet Relay Chat (IRC): kathenas Matrix: #kathenas:matrix.org Website: https://kathenas.org Instagram: https://instagram.com/kathenasorg/ Threads: https://www.threads.net/@kathenasorg --
Attachment:
signature.asc
Description: This is a digitally signed message part