Akash,
It looks like you updated debian/patches/0001-remove-licence-installation-
from-makefile.patch. You should probably mention this in the changelog.
Something along the lines of:
* Refresh debian/patches/0001-remove-licence-installation-from-makefile.patch.
Once you get that fixed, I think it should be ready to release.
Soren
On Saturday, September 7, 2024 1:31:30 PM MST Soren Stoutner wrote:
> Control: owner -1 !
>
> Akash,
>
> I will take a look at this as I sponsored a previous release of ereandel.
>
> As a general rule I usually am willing to sponsor updates to programs I have
> sponsored in the past. You can often just upload the update to Salsa and
ping
> me with an email. You don’t need to go through mentors and the RFS process
> (unless I am unresponsive for some reason or you would just like someone
else
> to take a look).
>
> On Saturday, September 7, 2024 2:52:54 AM MST Phil Wyett wrote:
> > Control: tags -1 +confirmed
> >
> > Akash,
> >
> > Preamble...
> >
> > Thank you for taking the time to prepare this package and your
contribution
> > to the Debian project.
> >
> > The review below is for assistance. This review is offered to help package
> > submitters to Debian mentors inorder to improve their packages prior to
> > possible sponsorship into Debian. There is no obligation on behalf of the
> > submitter to make any alterations based upon information provided in the
> > review.
> >
> > Review...
> >
> > 1. Build:
> > * pbuilder [1]: Good
> > * sbuild [2]: Good
> >
> > 2. Lintian [3]: Good
> >
> > 3. Licenses [4]: Good
> >
> > 4. Watch file [uscan --force-download]: Good
> >
> > 5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good
> >
> > 6. Reproducible builds [5]: Good
> >
> > 7. Install [No previous installs]: Good
> >
> > 8. Upgrade [Over previous installs if any]: Good
> >
> > Summary...
> >
> > I believe ereandel is ready for review/possible sponsorship. Could a
Debian
> > Developer (DD) with available free time, please review this package and
> > upload if you feel it is ready.
> >
> > Regards
> >
> > Phil
> >
> > [1] pbuilder:
> > * Command: sudo pbuilder build <PACKAGE>.dsc
> > * Document: https://wiki.ubuntu.com/PbuilderHowto.
> > * Document: https://wiki.debian.org/PbuilderTricks
> >
> > [2] sbuild:
> > * Command: sbuild <PACKAGE>.dsc
> > * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/
Article00000002
> > * Document: https://wiki.debian.org/sbuild
> >
> > [3] lintian:
> > * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc,
> >
> > *.changes, *.buildinfo). Each can throw up different results, so be
> > thorough.
> >
> > * Document: https://wiki.debian.org/Lintian
> >
> > [4] lrc:
> > * Command: lrc
> > * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon
> >
> > [5] reprotest
> >
> > * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --
>
> auto-
>
> > build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
> >
> > * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/
Article00000004
> > * Document: https://wiki.debian.org/ReproducibleBuilds/
> > * Document: https://wiki.debian.org/ReproducibleBuilds/
Howto#Newer_method
--
Soren Stoutner
soren@debian.org