Hi,
Le 01/09/2024 à 08:58, Phil Wyett a écrit :
Morning Carmine,
Many thanks for addressing all the things mentioned.
Do not worry that you have made a new upstream release since the
original
submission. At this time I understand you wish to get the package
first into
Debian and then go from there. It is not necessary for it to be
latest when
entering Debian, as we know, the process can take time and releases
maybe
made during the process.
I hope Pierre can look at the package soon.
Regards
Phil
On Sun, 2024-09-01 at 08:43 +0200, carmix wrote:
Hi Phil,
I just adjusted with your suggestions,
as for the warning referred to the new upstream version, it is true on
the github repository I just made a new release,
but I would like it to stay around for a while before uploading it to
debian just to be sure that it is really stable,
Regards,
Carmine
Thanks for the new work on this package! It looks really good.
Only two things remaining for me:
- Most importantly, I could like to see (outside of the debian/
directory) that Carmix holds the copyright. This can be done in a file
at the root or in the headers of the source files.
As it is now, it is clear that the package is under GPL3, but the
copyright holder is not written. It would be good to have the
information that Carmix holds the copyright and that the license if
"GPL3 or later", as d/copyright summarizes.
The rationale is that the copyright should be clear from the sole orig
tarball.
- Very minor: there is still "Higlighting" somewhere in the source code.
After that, I will be ready to sponsor.
Cheers,