Andrea, On Tuesday, August 13, 2024 12:33:57 AM MST Andrea Pappacoda wrote: > Il 12 agosto 2024 21:55:03 CEST, Soren Stoutner <soren@debian.org> ha scritto: > >1. markdown source: quilt-patch-missing-description [debian/patches/ > >debian.patch] > > > >Could you please add a description to this patch? > > I thought at this, but as I haven't written the patch myself I'm not sure what > to write. It's a patch that Bastian created while converting the package to > the 3.0 (quilt) source format. Since it does different things, I might try to > split it up in different smaller patches and document them individually. Does > it make sense to you? Sure, that sounds like a great solution. > >3. P: markdown source: silent-on-rules-requiring-root [debian/control] > > > >I am assuming your program doesn’t require root to build (few do). If so, > >please add the line “Rules-Requires-Root: no” to debian/control. > > That's a false positive. Rules-Requires-Root: no is already implied by the > build dependency on dpkg-build-api (= 1). Please see dpkg-build-api(7) and > bug #1057176. I also think that adding a lintian override is wrong since this > should really be fixed lintian-side. Even so, it is considered good practice in Debian to explicitly state "Rules- Requires-Root: no” in the control file, and there are no downsides to doing so. It shows that the developer has explicitly considered the need for root during building time and is confident it isn’t needed. Setting "dpkg-build-api (= 1)" might or might not indicate the maintainer has specifically considered whether root is needed during build time. It ought to indicate that, but it could also indicate the developer specified that for other reasons without being fully aware of all the implications. -- Soren Stoutner soren@debian.org
Attachment:
signature.asc
Description: This is a digitally signed message part.