Dear Phil, Thank you so much for taking the time to review my package. I have updated the standards-version and the VCS fields.Please find the updated package here <https://salsa.debian.org/s20n/python-keep> and here <https://mentors.debian.net/package/python-keep/>
Regards, Shriram Ravindranathan On 06/08/24 17:35, Phil Wyett wrote:
Control: tags -1 +moreinfo On Mon, 1 Apr 2024 20:48:02 +0530 Shriram Ravindranathan <s20n@ters.dev> wrote:Dear Mentors, This package "python-keep" is a dependency of the new upstream version of another package that I am adopting called "howdoi" <https://tracker.debian.org/pkg/howdoi> Neither of these packages have salsa repositories under the debian group yet. Could you please create these two repositories for me? Thanking you, -- Shriram RavindranathanShriram, I am going to do a full review as this package has languished. Preamble... Thank you for taking the time to prepare this package and your contribution to the Debian project. The review below is for assistance. This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review. Review... 1. Build: * pbuilder [1]: Good * sbuild [2]: Good 2. Lintian [3]: Good 3. Licenses [4]: Good 4. Watch file [uscan --force-download]: Good 5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good 6. Reproducible builds [5]: Good 7. Install [No previous installs]: Good 8. Upgrade [Over previous installs if any]: N/A Additional... A. Please update 'Standards-Version' in 'debian/control' to latest version 4.7.0 as per Debian policy[6]. B. Please create a repository on Salsa in your own account/namespace and adjust the Vcs fields. This repository can then be moved into the 'debian' group once the package has been accepted into Debian. C. Please consider joinigng the Debian Python Team as has been previously asked. Under this group you will likely find more help and assistance not just now but in the future as you maintain this and other python packages. Summary... I believe python-keep is not yet ready for sponsorship/upload. Could the contributor rectify one of more of the rasied issues. Once updated to your satisfaction and a new upload done, please remove the 'moreinfo' on the Request For Sponsorship (RFS) bug report. Regards Phil [1] pbuilder: * Command: sudo pbuilder build <PACKAGE>.dsc * Document: https://wiki.ubuntu.com/PbuilderHowto. * Document: https://wiki.debian.org/PbuilderTricks [2] sbuild: * Command: sbuild <PACKAGE>.dsc * Document: https://wiki.debian.org/sbuild [3] lintian: * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough. * Document: https://wiki.debian.org/Lintian [4] lrc: * Command: lrc -t * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon [5] reprotest * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto- build <PACKAGE>dsc -- schroot unstable-amd64-sbuild * Document: https://wiki.debian.org/ReproducibleBuilds/ * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method [6] https://www.debian.org/doc/debian-policy/
Attachment:
OpenPGP_signature.asc
Description: OpenPGP digital signature