Evening Carmix,
Thanks. You have done good work on the package and users will make good use of
the package in the future. hexwalk was in a curated list of packages I put
forward to the Debian devel mailing list requesting for DDs to look at, so
here's hoping for sponsorship sooner rather than later.
Regards
Phil
On Sun, 2024-07-07 at 18:49 +0200, carmix wrote:
> Thank you Phil,
>
> I have corrected also these minor issues,
>
> now let's hope that some Debian Developer will upload it,
>
> Thank you very much,
>
> Carmix
>
> On 29/06/2024 22:09, Phil Wyett wrote:
> > Hi Carmix,
> >
> > Preamble...
> >
> > Thanks for updating your package contribution.
> >
> > The below review is for assistance. It is offered to help submitters of
> > packages to Debian mentors improve their packages prior to possible
> > sponsorship into Debian. There is no obligation on behalf of the subitter to
> > make any alterations based upon information provided in the review.
> >
> > Review...
> >
> > 1. Build: Good
> >
> > 2. Lintian: Warning / Issue
> >
> > W: hexwalk: description-synopsis-starts-with-article
> > N:
> > N: The first line of the "Description:" should omit any initial indefinite or
> > N: definite article: "a", "an", or "the". A good heuristic is that it should
> > N: be possible to substitute the package name and synopsis into this formula:
> > N:
> > N: The package name provides {a,an,the,some} synopsis.
> > N:
> > N: Please refer to The package synopsis, or short description (Section 6.2.2)
> > N: in the Debian Developer's Reference for details.
> > N:
> > N: Visibility: warning
> > N: Show-Always: no
> > N: Check: fields/description
> >
> > This is my fault with the suggestion I made previously - Sorry Carmix.
> >
> > Remove the 'A' from the start and we should be good.
> >
> > W: hexwalk: possible-unindented-list-in-extended-description line 6
> > N:
> > N: The package "Description:" contains an unindented line which starts with a
> > N: dash (-) or asterisk (*). If this was meant to be a list of items these
> > N: lines need to be indented (dselect would word-wrap these lines otherwise).
> > N:
> > N: Please refer to Description (Section 5.6.13) in the Debian Policy Manual
> > N: for details.
> > N:
> > N: Visibility: warning
> > N: Show-Always: no
> > N: Check: fields/description
> >
> > 1. The list at the bottom of the description needs to be indented.
> >
> > 3. Licenses: Good
> >
> > 4. Build Twice (sudo pbuilder build --twice <package>.dsc): Good
> >
> > 5. Reproducible builds (reporotest)[1]: Good
> >
> > 6. Install (No previous installs): Good
> >
> > 7. Upgrade (Over previous installs if any): N/A
> >
> > Summary...
> >
> > These are quick fixes that can be performed now if the contributor wishes or in a later upload.
> >
> > A manual page would be advantageous in the future Carmix and good practise for if you ever wished to
> > apply for another status (DM,DD) within the Debian project.
> >
> > I believe hexwalk is now ready for sponsorship/upload. Could a Debian Developer (DD) with available
> > free time, please review this package and upload if you feel it is ready and appropriate for the
> > distribution.
> >
> > [1] https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method
> >
> > Regards
> >
> > Phil
> >
--
Internet Relay Chat (IRC): kathenas
Website: https://kathenas.org
Instagram: https://instagram.com/kathenasorg/
Buy Me A Coffee: https://buymeacoffee.com/kathenasorg
Attachment:
signature.asc
Description: This is a digitally signed message part