Bug#1074592: RFS: selint/1.5.0-2 -- Static code analysis of refpolicy style SELinux policies
On Sat, 6 Jul 2024 at 21:33, Pierre Gruet <pgt@debian.org> wrote:
>
> Hello Christian,
>
> On Wed, 03 Jul 2024 17:04:44 +0100 Phil Wyett
> <philip.wyett@kathenas.org> wrote:
> > Hi Christian,
> >
> > Preamble...
> >
> > Thanks for taking time to create this package and your contribution
> to Debian.
> >
> > The below review is for assistance. It is offered to help submitters of
> > packages to Debian mentors improve their packages prior to possible
> > sponsorship into Debian. There is no obligation on behalf of the
> subitter to
> > make any alterations based upon information provided in the review.
> >
> > Review...
> >
> > 1. Build: Good
> >
> > 2. Lintian: Good
> >
> > 3. Licenses: Issue
> >
> >
> philwyett@ks-windu:~/Development/builder/debian/mentoring/selint-1.5.0$ lrc
> > en: Versions: recon 1.11 check 3.3.9-1
> >
> > Parsing Source Tree ....
> > Reading copyright ....
> > Running licensecheck ....
> >
> > d/copyright | licensecheck
> >
> > Apache-2.0 | FSFAP INSTALL
> >
> > It would be nice if this minor issue could be fixed in this upload.
> >
> > 4. Build Twice (sudo pbuilder build --twice <package>.dsc): Good
> >
> > 5. Reproducible builds (reporotest)[1]: Good
> >
> > 6. Install (No previous installs): Good
> >
> > 7. Upgrade (Over previous installs if any): Good
> >
> > [1] https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method
> >
> > Summary...
> >
> > Excluding the one minor issue, I believe selint is ready for
> sponsorship/upload. Could a Debian
> > Developer (DD) with available free time, please review this package
> and upload if you feel it is
> > ready.
Thanks for your review Phil.
I wasn't aware of licenserecon, I try to add it to my packaging routine.
(Could you please include nnn-submitter@bugs.debian.org in the
recipient list, otherwise the bug submitters won't get notified.)
>
> Nothing more to say. I also reviewed the packaging and my only remark is
> also on the copyright: can you please acknowledge in d/copyright that
> INSTALL is under FSFAP with copyright owned by the FSF?
Added a new commit and uploaded to mentors.
> After that, just tell me and I can upload the package for you.
>
> Also a side note: in general it is better not to tag the commit until
> the package is really uploaded, especially if you are asking for
> sponsorship, as some changes may be suggested afterwards as is the case
> here.
Thanks, will try to do; removed the tag for now,
>
> Thanks for all the work!
>
> And thanks to Phil also for the first review :)
>
> Best,
>
> --
> Pierre
Reply to: