Bug#1071531: RFS: fvwm3/1.1.0+ds-1 -- F(?) Virtual Window Manager
On Wed, 2024-05-29 at 19:02 +0100, Phil Wyett wrote:
> Hi Jaimos,
>
> Many thanks for taking the time to package this application.
>
> Package builds perfect, the only issues I see is with 'debian/copyright'.
> Running 'lrc' against the tree we get the below output.
>
> Parsing Source Tree ....
> Reading copyright ....
> Running licensecheck ....
>
> d/copyright | licensecheck
>
> GPL-2 | GPL-2+ bin/fvwm-convert-2.6.in
> GPL-2 | GPL-2+ bin/fvwm-menu-directory.in
> GPL-2 | GPL-2+ bin/fvwm-menu-xlock.in
> GPL-2 | GPL-2+ bin/fvwm-perllib.in
> GPL-2 | GPL-2+ bin/fvwm-root.c
> GPL-2 | GPL doc/fvwm3_manpage_source.adoc
> GPL-2 | GPL-2+ fvwm/add_window.c
> GPL-2 | GPL-2+ fvwm/bindings.c
> GPL-2 | GPL-2+ fvwm/borders.c
> GPL-2 | GPL-2+ fvwm/builtins.c
> GPL-2 | GPL-2+ fvwm/cmdparser_old.c
> GPL-2 | GPL-2+ fvwm/colormaps.c
> GPL-2 | GPL-2+ fvwm/colormaps.h
> GPL-2 | GPL-2+ fvwm/colorset.c
> GPL-2 | GPL-2+ fvwm/conditional.c
> GPL-2 | GPL-2+ fvwm/condrc.c
> GPL-2 | GPL-2+ fvwm/cursor.c
> GPL-2 | GPL-2+ fvwm/decorations.c
> GPL-2 | GPL-2+ fvwm/events.c
> GPL-2 | GPL-2+ fvwm/ewmh.c
> GPL-2 | GPL-2+ fvwm/ewmh_conf.c
> GPL-2 | GPL-2+ fvwm/ewmh_events.c
> GPL-2 | GPL-2+ fvwm/ewmh_icons.c
> GPL-2 | GPL-2+ fvwm/ewmh_names.c
> GPL-2 | GPL-2+ fvwm/execcontext.c
> GPL-2 | GPL-2+ fvwm/expand.c
> GPL-2 | GPL-2+ fvwm/focus.c
> GPL-2 | GPL-2+ fvwm/focus_policy.c
> GPL-2 | GPL-2+ fvwm/frame.c
> GPL-2 | GPL-2+ fvwm/functable.c
> GPL-2 | GPL-2+ fvwm/functable_complex.c
> GPL-2 | GPL-2+ fvwm/functions.c
> GPL-2 | GPL-2+ fvwm/fvwm3.c
> GPL-2 | GPL-2+ fvwm/geometry.c
> GPL-2 | GPL-2+ fvwm/icccm2.c
> GPL-2 | GPL-2+ fvwm/icons.c
> GPL-2 | GPL-2+ fvwm/infostore.c
> GPL-2 | GPL-2+ fvwm/menubindings.c
> GPL-2 | GPL-2+ fvwm/menucmd.c
> GPL-2 | GPL-2+ fvwm/menudim.c
> GPL-2 | GPL-2+ fvwm/menugeometry.c
> GPL-2 | GPL-2+ fvwm/menuitem.c
> GPL-2 | GPL-2+ fvwm/menus.c
> GPL-2 | GPL-2+ fvwm/menustyle.c
> GPL-2 | GPL-2+ fvwm/misc.c
> GPL-2 | GPL-2+ fvwm/modconf.c
> GPL-2 | GPL-2+ fvwm/module_interface.c
> GPL-2 | GPL-2+ fvwm/module_list.c
> GPL-2 | GPL-2+ fvwm/move_resize.c
> GPL-2 | GPL-2+ fvwm/placement.c
> GPL-2 | GPL-2+ fvwm/read.c
> GPL-2 | GPL-2+ fvwm/schedule.c
> GPL-2 | NTP~disclaimer fvwm/screen.h
> GPL-2 | GPL-2+ fvwm/session.c
> GPL-2 | GPL-2+ fvwm/stack.c
> GPL-2 | GPL-2+ fvwm/style.c
> GPL-2 | GPL-2+ fvwm/update.c
> GPL-2 | GPL-2+ fvwm/virtual.c
> GPL-2 | GPL-2+ fvwm/windowlist.c
> GPL-2 | GPL-2+ fvwm/windowshade.c
> GPL-2 | ISC libs/asprintf.c
> GPL-2 | GPL-2+ libs/BidiJoin.c
> GPL-2 | GPL-2+ libs/Bindings.c
> GPL-2 | GPL-2+ libs/charmap.c
> GPL-2 | Expat libs/cJSON.c
> GPL-2 | Expat libs/cJSON.h
> GPL-2 | GPL-2+ libs/ClientMsg.c
> GPL-2 | GPL-2+ libs/Colorset.c
> GPL-2 | LGPL-2+ libs/ColorUtils.c
> GPL-2 | GPL-2+ libs/CombineChars.c
> GPL-2 | GPL-2+ libs/Cursor.c
> GPL-2 | GPL-2+ libs/envvar.c
> GPL-2 | GPL-2+ libs/Event.c
> GPL-2 | GPL-2+ libs/FBidi.c
> GPL-2 | GPL-2+ libs/FEvent.c
> GPL-2 | GPL-2+ libs/Fft.c
> GPL-2 | GPL-2+ libs/FGettext.c
> GPL-2 | GPL-2+ libs/Ficonv.c
> GPL-2 | GPL-2+ libs/FImage.c
> GPL-2 | GPL-2+ libs/fio.c
> GPL-2 | GPL-2+ libs/flist.c
> GPL-2 | GPL-2+ and/or NTP libs/Flocale.c
> GPL-2 | GPL-2+ libs/FlocaleCharset.c
> GPL-2 | GPL-2+ libs/fqueue.c
> GPL-2 | GPL-2+ libs/FRender.c
> GPL-2 | GPL-2+ libs/FRenderInit.c
> GPL-2 | GPL-2+ libs/FScreen.c
> GPL-2 | GPL-2+ libs/FShape.c
> GPL-2 | GPL-2+ libs/fsm.c
> GPL-2 | GPL-2+ libs/FTips.c
> GPL-2 | GPL-2+ libs/fvwmlib3.c
> GPL-2 | GPL-2+ libs/fvwmrect.c
> GPL-2 | GPL-2+ libs/fvwmsignal.c
> GPL-2 | GPL-2+ libs/getpwuid.c
> GPL-2 | GPL-2+ libs/getpwuid.h
> GPL-2 | GPL-2+ libs/Grab.c
> GPL-2 | GPL-2+ libs/Graphics.c
> GPL-2 | GPL-2+ libs/gravity.c
> GPL-2 | ISC libs/log.c
> GPL-2 | GPL-2+ libs/modifiers.c
> GPL-2 | GPL-2+ libs/Module.c
> GPL-2 | GPL-2+ libs/Parse.c
> GPL-2 | GPL-2+ libs/PictureBase.c
> GPL-2 | GPL-2+ libs/Picture.c
> GPL-2 | GPL-2+ libs/PictureGraphics.c
> GPL-2 | GPL-2+ libs/PictureImageLoader.c
> GPL-2 | GPL-2+ libs/PictureUtils.c
> GPL-2 | BSD-3-clause libs/queue.h
> GPL-2 | GPL-2+ libs/Rectangles.c
> GPL-2 | GPL-2+ libs/setpgrp.c
> GPL-2 | GPL-2+ libs/Strings.c
> GPL-2 | ISC libs/strlcat.c
> GPL-2 | ISC libs/strlcat.h
> GPL-2 | ISC libs/strlcpy.c
> GPL-2 | ISC libs/strlcpy.h
> GPL-2 | ISC libs/strtonum.c
> GPL-2 | ISC libs/strtonum.h
> GPL-2 | GPL-2+ libs/System.c
> GPL-2 | GPL-2+ libs/Target.c
> GPL-2 | GPL-2+ libs/timeout.c
> GPL-2 | BSD-2-clause libs/tree.h
> GPL-2 | GPL-2+ libs/wcontext.c
> GPL-2 | GPL-2+ libs/wild.c
> GPL-2 | GPL-2+ libs/WinMagic.c
> GPL-2 | GPL-2+ libs/XError.c
> GPL-2 | GPL-2+ libs/XResource.c
> GPL-2 | GPL-2+ modules/FvwmAnimate/FvwmAnimate.c
> GPL-2 | GPL-2+ modules/FvwmAuto/FvwmAuto.c
> GPL-2 | GPL-2+ modules/FvwmBacker/FvwmBacker.c
> GPL-2 | GPL-2+ modules/FvwmBacker/FvwmBacker.h
> GPL-2 | GPL-2+ modules/FvwmBacker/root_bits.c
> GPL-2 | GPL-2+ modules/FvwmButtons/button.c
> GPL-2 | GPL-2+ modules/FvwmButtons/draw.c
> GPL-2 | GPL-2+ modules/FvwmButtons/dynamic.c
> GPL-2 | GPL-2+ modules/FvwmButtons/FvwmButtons.c
> GPL-2 | GPL-2+ modules/FvwmButtons/icons.c
> GPL-2 | GPL-2+ modules/FvwmButtons/icons.h
> GPL-2 | GPL-2+ modules/FvwmButtons/misc.c
> GPL-2 | GPL-2+ modules/FvwmButtons/misc.h
> GPL-2 | GPL-2+ modules/FvwmButtons/output.c
> GPL-2 | GPL-2+ modules/FvwmButtons/parse.c
> GPL-2 | GPL-2+ modules/FvwmButtons/parse.h
> GPL-2 | GPL-2+ modules/FvwmConsole/FvwmConsole.c
> GPL-2 | GPL-2+ modules/FvwmConsole/FvwmConsoleC.c
> GPL-2 | GPL-2+ modules/FvwmConsole/getline.c
> GPL-2 | GPL-2+ modules/FvwmEvent/FvwmEvent.c
> GPL-2 | GPL-2+ modules/FvwmForm/FvwmForm.c
> GPL-2 | GPL-2+ modules/FvwmForm/ParseCommand.c
> GPL-2 | GPL-2+ modules/FvwmForm/ReadXServer.c
> GPL-2 | GPL-2+ modules/FvwmIconMan/debug.c
> GPL-2 | GPL-2+ modules/FvwmIconMan/functions.c
> GPL-2 | GPL-2+ modules/FvwmIconMan/fvwm.c
> GPL-2 | GPL-2+ modules/FvwmIconMan/FvwmIconMan.c
> GPL-2 | GPL-2+ modules/FvwmIconMan/globals.c
> GPL-2 | GPL-2+ modules/FvwmIconMan/readconfig.c
> GPL-2 | GPL-2+ modules/FvwmIconMan/winlist.c
> GPL-2 | GPL-2+ modules/FvwmIconMan/x.c
> GPL-2 | GPL-2+ modules/FvwmIconMan/xmanager.c
> GPL-2 | GPL-2+ modules/FvwmIdent/FvwmIdent.c
> GPL-2 | GPL-2+ modules/FvwmPager/FvwmPager.c
> GPL-2 | GPL-2+ modules/FvwmPager/x_pager.c
> GPL-2 | GPL-2+ modules/FvwmPerl/FvwmPerl.in
> GPL-2 | GPL-2+ modules/FvwmRearrange/FvwmRearrange.c
> GPL-2 | GPL-2+ modules/FvwmScript/FvwmScript.c
> GPL-2 | GPL-2+ modules/FvwmScript/Instructions.c
> GPL-2 | GPL-2+ modules/FvwmScript/scanner.l
> GPL-2 | GPL-2+ with Bison-2.2 exception modules/FvwmScript/script.c
> GPL-2 | GPL-2+ with Bison-2.2 exception modules/FvwmScript/script.h
> GPL-2 | GPL-2+ modules/FvwmScript/script.y
> GPL-2 | GPL-2+ modules/FvwmScript/Widgets/CheckBox.c
> GPL-2 | GPL-2+ modules/FvwmScript/Widgets/HDipstick.c
> GPL-2 | GPL-2+ modules/FvwmScript/Widgets/HScrollBar.c
> GPL-2 | GPL-2+ modules/FvwmScript/Widgets/ItemDraw.c
> GPL-2 | GPL-2+ modules/FvwmScript/Widgets/List.c
> GPL-2 | GPL-2+ modules/FvwmScript/Widgets/Menu.c
> GPL-2 | GPL-2+ modules/FvwmScript/Widgets/MiniScroll.c
> GPL-2 | GPL-2+ modules/FvwmScript/Widgets/PopupMenu.c
> GPL-2 | GPL-2+ modules/FvwmScript/Widgets/PushButton.c
> GPL-2 | GPL-2+ modules/FvwmScript/Widgets/RadioButton.c
> GPL-2 | GPL-2+ modules/FvwmScript/Widgets/Rectangle.c
> GPL-2 | GPL-2+ modules/FvwmScript/Widgets/Swallow.c
> GPL-2 | GPL-2+ modules/FvwmScript/Widgets/TextField.c
> GPL-2 | GPL-2+ modules/FvwmScript/Widgets/Tools.c
> GPL-2 | GPL-2+ modules/FvwmScript/Widgets/VDipstick.c
> GPL-2 | GPL-2+ modules/FvwmScript/Widgets/VScrollBar.c
> GPL-2 | GPL-2+ modules/FvwmScript/Widgets/Widget.c
> GPL-2 | GPL-2+ perllib/FVWM/EventNames.pm
> GPL-2 | GPL-2+ perllib/FVWM/Event.pm
> GPL-2 | GPL-2+ perllib/FVWM/Module.pm.in
> GPL-2 | GPL-2+ perllib/FVWM/Module/Terminal.pm
> GPL-2 | GPL-2+ perllib/FVWM/Module/Toolkit.pm
> GPL-2 | GPL-2+ perllib/FVWM/Tracker/Colorsets.pm
> GPL-2 | GPL-2+ perllib/FVWM/Tracker/GlobalConfig.pm
> GPL-2 | GPL-2+ perllib/FVWM/Tracker/ModuleConfig.pm
> GPL-2 | GPL-2+ perllib/FVWM/Tracker/PageInfo.pm
> GPL-2 | GPL-2+ perllib/FVWM/Tracker.pm
> GPL-2 | GPL-2+ perllib/FVWM/Tracker/Scheduler.pm
> GPL-2 | GPL-2+ perllib/FVWM/Tracker/WindowList.pm
> GPL-2 | GPL-2+ perllib/General/FileSystem.pm
> GPL-2 | GPL-2+ perllib/General/Parse.pm
>
> I have looked at a few of the files and indeed a lot of the files are GPL-2+ or
> other license. Please could you have a bit of an audit and update the
> 'debian/copyright' file where appropriate.
>
> Regards
>
> Phil
>
Hi Jaimos,
Many thanks for the additional work to the package, especially
'debian/copyright'. The package looks good and I feel is ready for upload with
any additional work being done as part of your constant package maintenance
Reply to: