Bug#979188: RFS: git-subrepo/0.4.3-1 [ITP] -- Alternative to git-submodule(1) and git-subtree(1)
- To: Daniel Gröber <dxld@darkboxed.org>, 979188@bugs.debian.org
- Subject: Bug#979188: RFS: git-subrepo/0.4.3-1 [ITP] -- Alternative to git-submodule(1) and git-subtree(1)
- From: Samo Pogačnik <samo_pogacnik@t-2.net>
- Date: Sat, 01 Jun 2024 10:01:53 +0200
- Message-id: <[🔎] 9c67b56135ec4a4bcae90d241b94408df10b2dac.camel@t-2.net>
- Reply-to: Samo Pogačnik <samo_pogacnik@t-2.net>, 979188@bugs.debian.org
- In-reply-to: <20240528172309.mt6rehrx6upnsq72@House.clients.dxld.at>
- References: <20210104012648.tq7clgbqvitfxltn@Eli.clients.dxld.at> <20240506130219.7r7hljhqz4xjma7i@House.clients.dxld.at> <20210104012648.tq7clgbqvitfxltn@Eli.clients.dxld.at> <f49917559b5670ecc50db179980c5bdfbd73be1c.camel@t-2.net> <c93c584cd6cdf83d2f02068671786556355fcc44.camel@t-2.net> <20240523144012.ttukj7cf5w5gl34f@darkboxed.org> <7a93d3da137d7d5f99799e698f1bab9c43200deb.camel@t-2.net> <20210104012648.tq7clgbqvitfxltn@Eli.clients.dxld.at> <20240528172309.mt6rehrx6upnsq72@House.clients.dxld.at> <20210104012648.tq7clgbqvitfxltn@Eli.clients.dxld.at>
Hi Daniel,
Dne 28.05.2024 (tor) ob 19:23 +0200 je Daniel Gröber napisal(a):
> I'm not super happy with the approach of putting git-subrepo.d inside
> /usr/share/git-subrepo tbh. I might be able to let it pass but it seems
> lintian found another issue that needs patching anyway so you may as well
> fix this too.
>
> W: git-subrepo: bash-completion-with-hashbang bash [usr/share/bash-
> completion/completions/git-subrepo:1]
> W: git-subrepo: executable-not-elf-or-script [usr/share/git-subrepo/git-
> subrepo.d/bash+.bash]
> W: git-subrepo: mismatched-override executable-not-elf-or-script
> usr/lib/git-core/git-subrepo.d/bash+.bash [usr/share/lintian/overrides/git-
> subrepo:1]
> N: 0 hints overridden; 1 unused override
>
> indeed bash+.bash is +x but shouldn't be.
>
> I'm not sure whether bash-completion-with-hashbang should really be W
> severity but the '#!bash' it has is certainly completely wrong. Looks like
> you'll have to get over your fear of patching upstream ;)
>
I prepared a new 0.4.6-1 release (
https://salsa.debian.org/spog/git-subrepo/-/commit/ebbc6e9df46b479f1517a5dbd8486b95f511d5be
) with patched upstream regarding:
- bash-completition integration with git
- executable permissions on sourced-only files
- hashbangs inside sourced-only files
I've also removed old lintian-override from debian/, since it is not required
anymore.
--Samo
Reply to: