[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#979188: RFS: git-subrepo/0.4.3-1 [ITP] -- Alternative to git-submodule(1) and git-subtree(1)



Hi Samo,

On Sat, May 25, 2024 at 07:30:46PM +0200, Samo Pogačnik wrote:
> https://salsa.debian.org/spog/git-subrepo/-/commit/42628d43faa4a05eb3dd3c4b75d9d194ce6bda90

I'm not super happy with the approach of putting git-subrepo.d inside
/usr/share/git-subrepo tbh. I might be able to let it pass but it seems
lintian found another issue that needs patching anyway so you may as well
fix this too.

    W: git-subrepo: bash-completion-with-hashbang bash [usr/share/bash-completion/completions/git-subrepo:1]
    W: git-subrepo: executable-not-elf-or-script [usr/share/git-subrepo/git-subrepo.d/bash+.bash]
    W: git-subrepo: mismatched-override executable-not-elf-or-script usr/lib/git-core/git-subrepo.d/bash+.bash [usr/share/lintian/overrides/git-subrepo:1]
    N: 0 hints overridden; 1 unused override

indeed bash+.bash is +x but shouldn't be.

I'm not sure whether bash-completion-with-hashbang should really be W
severity but the '#!bash' it has is certainly completely wrong. Looks like
you'll have to get over your fear of patching upstream ;)

--Daniel

Attachment: signature.asc
Description: PGP signature


Reply to: