[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1069894: RFS: gpscorrelate/2.1-1 -- correlates digital photos with GPS data filling EXIF fields (command line)



Dear Jeroen,

Thank you so much for the detailed review. I have made these changes and uploaded a new version <https://mentors.debian.net/package/gpscorrelate/>.

Summary of changes since last upload:

- Fix licenses in d/copyright

- Close ITA bug in changelog

- Remove version requirement for libexiv2-dev

- Remove gpscorrelate-gui.dirs

- Remove incorrect dependency of gpscorrelate on gpscorrelate-gui

- Remove override for dh_auto_test

- Add autopkgtest based on re2c's d/tests

On 06/05/24 17:37, Jeroen Ploemen wrote:
* d/README.Debian seems outdated; it talks about a rationale for
   splitting into two binary packages that aren't interdependent and
   only recommend one another for docs, but then d/control lists one as
   a hard dependency of the other. What changed? Does the README or the
   package need modification?

It seems like the README still holds true. Based on my analysis of the makefile, the two packages indeed appear to be independent of each other. I am however not 100% sure about this. I did a sanity check by removing the dependency and only installing the gui package and everything seemed to work fine.

Could you please also take a look at it, just to make sure? This dependency has been there since the very first commit <https://salsa.debian.org/debian/gpscorrelate/-/commit/90989886253b1c293435f532f775868d191a4048>. I have removed the dependency in the latest upload.

Thanking you,

--
Shriram Ravindranathan

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature


Reply to: