[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1058766: RFS: rdiffweb/2.8.7.dev41+g849af0c+dfsg-1 [ITP] -- web interface to rdiff-backup repositories



Control: tags -1 + moreinfo

On Fri, Dec 15, 2023 at 03:36:19PM -0500, Patrik Dufresne wrote:
>   dget -x https://mentors.debian.net/debian/pool/main/r/rdiffweb/rdiffweb_2.8.7.dev41+g849af0c+dfsg-1.dsc
> 
> Changes for the initial release:
> 
>  rdiffweb (2.8.7.dev41+g849af0c+dfsg-1) unstable; urgency=medium
>  .
>    * Automated build
Some problems I noticed after a short review:

- The package FTBFS: "E: pybuild pybuild:389: test: plugin distutils
  failed with: exit code=5: cd
  /<<PKGBUILDDIR>>/.pybuild/cpython3_3.11/build; python3.11 -m pytest".
- You should only have one changelog entry (also "Automated build" looks
  very suspicious there).
- Versioned (build-)depends on gzip and coreutils are satisfiable even in
  oldoldstable so they shouldn't be versioned.
- Standards-Version is outdated.
- rdw.conf going into both examples and /etc looks incorrect.
- Symlink stuff in postinst/postrm looks strange.
- /etc/rdiffweb seems to be created both during the package build and in
  postinst.

Note that some of these are detected by lintian and even shown on the
mentors page.
Please remove the moreinfo tag when these are addressed.

-- 
WBR, wRAR

Attachment: signature.asc
Description: PGP signature


Reply to: