[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1056643: marked as done (RFS: gtklock/2.1.0-1 [ITP] -- GTK-based lockscreen for wayland)

Your message dated Sun, 11 Feb 2024 12:15:30 +0100
with message-id <ZcisUpax1XwYzGGz@isildor2.loewenhoehle.ip>
and subject line Re: Bug#1056643: RFS: gtklock/2.1.0-1 [ITP] -- GTK-based lockscreen for wayland
has caused the Debian Bug report #1056643,
regarding RFS: gtklock/2.1.0-1 [ITP] -- GTK-based lockscreen for wayland
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1056643: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1056643
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Control: block 1052418 by -1
Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I am looking for a sponsor for my package "gtklock":

 * Package name     : gtklock
   Version          : 2.1.0-1
   Upstream contact : Jovan Lanik <jox969@gmail.com>
 * URL              : https://github.com/jovanlanik/gtklock
 * License          : GPL-3+
 * Vcs              : https://salsa.debian.org/Maytha8/gtklock
   Section          : misc

The source builds the following binary packages:

  gtklock - GTK-based lockscreen for wayland

To access further information about this package, please visit the following
URL:

  https://mentors.debian.net/package/gtklock/

Alternatively, you can download the package with 'dget' using this command:

  dget -x
https://mentors.debian.net/debian/pool/main/g/gtklock/gtklock_2.1.0-1.dsc

Changes for the initial release:

 gtklock (2.1.0-1) UNRELEASED; urgency=medium
 .
   * Initial release. (Closes: #1052418)

Regards,
- -- 
  Maytham Alsudany
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEESl/RzRFQh8wD3DXB1ZeJcgbF8H8FAmVgdFEACgkQ1ZeJcgbF
8H88mA/9GMRiflIID3HtYQx9Q64YYzxCy7+SwzXfFiDq3gPA+jm2DzrHQ6lK62Mr
W73SLWYF8P5gRDwdAuOzYr5kWMhn94YnDNvIOBAtieOE+uFTntHr3lb6Z+VrlL9t
jwH6BccJAtYDaGfk2CbNlaFD0OuVJVdpMfwl+YwCpB/JogqfddZc5xwe3Z9z1a4S
pHgFZRfao6qCPMnInDrjovfRifC3P+5kevNuJucxFcTZvia9I+begWZL3O6GGcKF
qArc7mrC9pBF/2i74vD7jtCyv/8iTQyA8408fQhLzzk0PkkL7++FbIWrC6H2Bqq7
2hn1X5NxWd8YkAvB4X/GvpPaadqyLdtpgSgMLUoHhA7qF7GshbinJFFjuV7+bmQ+
h1koTb+cLCGIlkQ3xhlIpEkftLFNqLy0RzeU3iy1nRhn81YicsUuv3GUdVMM/Bt5
eOgadZxbs3lkTUfnngyxyAJB48natNRjvNTaP5YvQMUOXzpQP9Htl1g4GoYY5XNw
+MbLoSgLDXD8mmDkeIJ1H7dCYKC/vgjpkmn6uVBjx0VcWDquQaaEDl9l6FDlH4SG
k1/uimBYLPQMGbx/4Bi5TaNiaosPpPt3H7CRSqi0t/eFVLz6beHgh6r7cTuSk3sf
UOVlArjpJo1WUKKy+84l1C9tgtC2s9ruslIaSQUnxW+OTBXGW94=
=vrTH
-----END PGP SIGNATURE-----

--- End Message ---
--- Begin Message --- 
Hi,

I've found some nitpicks, but please consider them… But that won't
hinder the upload, so I've uploaded the package. It will appear in NEW
soon and will require manual handling by the FTP masters.



- it fails to build in the unpacked source directory:

tobi@isildor2:~/workspace/deb/mentors/MaythamAlsudany/gtkklock/new/gtklock-2.1.0$ pdebuild
W: /home/tobi/.pbuilderrc does not exist
dpkg-checkbuilddeps: error: Unmet build dependencies: scdoc libpam0g-dev libwayland-dev libgtk-3-dev libgtk-layer-shell-dev
W: Unmet build-dependency in source
dh clean
   dh_auto_clean
	make -j1 distclean
make[1]: Entering directory '/home/tobi/workspace/deb/mentors/MaythamAlsudany/gtkklock/new/gtklock-2.1.0'
Package pam was not found in the pkg-config search path.
Perhaps you should add the directory containing `pam.pc'
to the PKG_CONFIG_PATH environment variable
Package 'pam', required by 'virtual:world', not found
Package pam was not found in the pkg-config search path.
Perhaps you should add the directory containing `pam.pc'
to the PKG_CONFIG_PATH environment variable
Package 'pam', required by 'virtual:world', not found
Package wayland-client was not found in the pkg-config search path.
Perhaps you should add the directory containing `wayland-client.pc'
to the PKG_CONFIG_PATH environment variable
Package 'wayland-client', required by 'virtual:world', not found
Package 'gtk+-wayland-3.0', required by 'virtual:world', not found
Package 'gtk-layer-shell-0', required by 'virtual:world', not found
Package 'gmodule-export-2.0', required by 'virtual:world', not found
makefile:30: *** recipe commences before first target.  Stop.
make[1]: Leaving directory '/home/tobi/workspace/deb/mentors/MaythamAlsudany/gtkklock/new/gtklock-2.1.0'
dh_auto_clean: error: make -j1 distclean returned exit code 2
make: *** [debian/rules:6: clean] Error 25

(it builds with pbuilder build *.dsc though, but this is an annoyance.
Possibly override dh_clean and instruct it to ignore errors. Better
would be, if upstream uses some established build system generator, like
cmake and autotools, as they know all those corner cases…)

- Lintian Warning:
W: gtklock source: build-depends-on-obsolete-package Build-Depends: pkg-config => pkgconf

- Please suggest to upstream for a per-file copyright statement.
https://lu.is/2012/03/on-the-importance-of-per-file-license-information/

- Note regarding d/copyright: (nothing you need to fix, you are fine,
thats a FYI that might make your live easier):
You can collapse Files: sections into one section, if the license is the
same, even if there are different copyright holders and copyright years.
For example, it ok to write:

Files: *
Copyright: 2022-2023 Jovan Lanik <jox969@gmail.com>
           2022 Kenny Levinsen
	   2022 Louis DeLosSantos
           (...)

- I'm not a fan of repositories for packaging in personal namespaces. Do
  you want me to create one in the debian namespace and grant you access
  to it? Note: the Debian namespace is collaborative maintainance, which
  is a good thing, but has side effects, as it allows other people to
  help with maintainance. See https://wiki.debian.org/Salsa/Doc#Collaborative_Maintenance:_.22Debian.22_group


Cheers,
tobi


On Mon, Jan 01, 2024 at 08:32:01AM +0800, Maytham Alsudany wrote:
> Hi Matthias,
> > The copyright stil has some issues:
> > 
> > src/input-inhibitor.c is MIT-licensed.
> 
> 
> Fixed.
> 
> Kind regards,
> Maytham

Attachment: signature.asc
Description: PGP signature


--- End Message ---
Reply to: