On Fri, 2024-01-12 at 20:45 +0800, Bo YU wrote:
> Hi!
>
> On Fri, Jan 12, 2024 at 2:30 PM Phil Wyett <philip.wyett@kathenas.org> wrote:
> >
> > On Fri, 2024-01-12 at 06:17 +0000, Phil Wyett wrote:
> > > On Fri, 2024-01-12 at 09:51 +0800, Bo YU wrote:
> > > > Package: sponsorship-requests
> > > > Severity: important
> > > >
> > > > Dear mentors,
> > > >
> > > > I am looking for a sponsor for my package "zfec":
> > > >
> > > > * Package name : zfec
> > > > Version : 1.5.7.4-0.1
> > > > Upstream contact : https://github.com/tahoe-lafs/zfec/issues
> > > > * URL : http://tahoe-lafs.org/trac/zfec
> > > > * License : GPL-2 or TGPPL1+, GPL-2 with OpenSSL exception or TGPPL-1
> > > > * Vcs : https://salsa.debian.org/vasudev/zfec
> > > > Section : python
> > > >
> > > > The source builds the following binary packages:
> > > >
> > > > python3-zfec - fast erasure codec, with Python 3 bindings
> > > >
> > > > To access further information about this package, please visit the following URL:
> > > >
> > > > https://mentors.debian.net/package/zfec/
> > > >
> > > > Alternatively, you can download the package with 'dget' using this command:
> > > >
> > > > dget -x https://mentors.debian.net/debian/pool/main/z/zfec/zfec_1.5.7.4-0.1.dsc
> > > >
> > > > Changes since the last upload:
> > > >
> > > > zfec (1.5.7.4-0.1) UNRELEASED; urgency=medium
> > > > .
> > > > * Non-maintainer upload.
> > > > * New upstream version 1.5.7.4. (Closes: #1055545)
> > > > * Drop debian/patch
> > > > * Demove upstream-vcs-tag when use gbp
> > > > * Ddd python3-pyutil on B-D.
> > > > * Add python3-hypothesis and python3-twisted for test.
> > > >
> > >
> > > Hi Bo,
> > >
> > > A quick look and test build.
>
> Thanks for sponsoring it!
> > >
> > > * Typo at start of second to last changelog entry in this update.
> > > * Need to change UNRELEASED.
> > > * In build:
> > >
> > > dpkg-gencontrol: warning: Recommends field of package python3-zfec: substitution
> > > variable
> > > ${python3:Recommends} used, but is not defined
> > > dpkg-gencontrol: warning: Suggests field of package python3-zfec: substitution
> > > variable
> > > ${python3:Suggests} used, but is not defined
> > > dpkg-gencontrol: warning: Recommends field of package python3-zfec: substitution
> > > variable
> > > ${python3:Recommends} used, but is not defined
> > > dpkg-gencontrol: warning: Suggests field of package python3-zfec: substitution
> > > variable
> > > ${python3:Suggests} used, but is not defined
> > >
> > > Regards
> > >
> > > Phil
> > >
> >
> > Oops, Also Typo at start of third line from end of this changelog entry.
> >
> Ah, sorry for these typo issues. I am not sure my finger on which keys
> of boards when building the package.:)
> All issues were addressed.
>
> And I remembered one NMU upload would like to be better as minimal as
> possible(please correct me If I am worng). So sometimes I ignore
> lintian warning. But I think this time it is okay to fix some
> lintian's warning as recorded in d/chanelog. I left one warning about
> missing of binary manual as it is.
>
> Thank you again, please review it again and let me know if any issues.
> ...
> To access further information about this package, please visit the
> following URL:
>
> https://mentors.debian.net/package/zfec/
>
> Alternatively, you can download the package with 'dget' using this command:
>
> dget -x https://mentors.debian.net/debian/pool/main/z/zfec/zfec_1.5.7.4-0.1.dsc
>
> Changes since the last upload:
>
> zfec (1.5.7.4-0.1) unstable; urgency=medium
> .
> * Non-maintainer upload.
> * New upstream version 1.5.7.4. (Closes: #1055545)
> * Drop debian/patch
> * Remove upstream-vcs-tag when use gbp
> * Add python3-pyutil on B-D.
> * Add python3-hypothesis and python3-twisted for test.
> * Remove python3:Recommends and python3:Suggests from d/control
> * Fix lintian issue:
> - Clear whitespace of debian/changelog
> - Set std-ver to 4.6.2
> - Set debhelper-compat to 13 and remove debian/compat
> - Add Rules-Requires-Root
>
>
> > Would also be nice to look at some of the Lintian issues also.
> >
> > Regards
> >
> > Phil
> >
> > --
> > Playing the game for the games sake.
> >
> > Web:
> >
> > * Debian Wiki: https://wiki.debian.org/PhilWyett
> > * Website: https://kathenas.org
> > * Social Debian: https://pleroma.debian.social/kathenas/
> > * Social Instagram: https://www.instagram.com/kathenasorg/
> >
> >
Hi Bo,
I am just as bad with the old typos on occasion, proves we are human. :-)
Minimal is better for NMU as you stated and you have with this upload done a lot in making
the package better and that is fantastic. I hope a DD will give it a review now and do the
upload for you.
Regards
Phil
--
Playing the game for the games sake.
Web:
* Debian Wiki: https://wiki.debian.org/PhilWyett
* Website: https://kathenas.org
* Social Debian: https://pleroma.debian.social/kathenas/
* Social Instagram: https://www.instagram.com/kathenasorg/
Attachment:
signature.asc
Description: This is a digitally signed message part