[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1028423: RFS: spek/0.8.5-1 [ITP] [RC] -- acoustic spectrum analyser



Hi Matteo,

Please address the following things and then I am going to sponsor spek:

Exclude the dist and web directories. There are several non-source files and files where the license is not clear.
This means introducing a Files-Excluded in debian/copyright and a repacksuffix in the watch file and in the changelog.
Please also exclude the lic directory (you can leave lic/GPL if you like) because those 3rd party licenses are not applicable to spek itself but Debian Policy would require you to copy them to d/copyright if you kept them.

The copyright for * has to be completed:
Copyright (c) 2010-2013 Alexander Kojevnikov and contributors

I guess the src/spek-pipeline.c copyright stems from upstream's debianization. On completing the general copyright you can drop that copyright paragraph because those copyrights are not explicitly mentioned (anymore).

In po/* there are several files mentioning
Copyright (C) YEAR The Spek authors
Even if that stems from a template, you have to copy this as-is.

There is no point in keeping Debian's spek.xpm and spek.install files after dropping the spek.menu file.
Please create a desktop file instead that refernces upstream's .svg.

Please drop debian/autoreconf.*.

There is not a high chance of this to enter bookworm.
But if you are very quick (< 1 week) with those changes maybe we and FTP Master can make it happen.

Cheers,
Bastian


Reply to: