Control: tags -1 moreinfo
Hi xibowen,
On Mon, Oct 30, 2023 at 11:23:33AM +0800, xibowen wrote:
> Hi. thanks for reply.
>
> >
> > I'm curious if libkysdk-base-common is really needed? This will also
> > require a NEW processing btw.
> >
>
> I have removed the libkysdk-base-common and uploaded to mentors.
>
> Lastest upload: https://mentors.debian.net/package/libkysdk-base/
>
> libkysdk-base (2.2.0.1-1) unstable; urgency=medium
> .
> * Update libs soname version.
> * Fix compile error on armhf and ppc64el.
> * d/control:
> - Add Multi-Arch.
(this is a partial review, as I ran out of time.)
- Updating the SONAME of a library requires this procedure to be followed:
https://wiki.debian.org/Teams/ReleaseTeam/Transitions
Comparing the symbols file does not make it obvious why you are
bumping SONAME, but I did not check with abi-complicance-checker...
Can you fill me in why you bump the soname?
- the breaks/replaces version seems odd, as it is a binnmu version.
You likely want (<< 2.2.0.1-1~), though I am not sure why you think
you'll need the Break/Replace? Can you exand?
- you could use d/clean instead of overriding dh_clean
- for the install files, for multiarch, a cleaner way would be to write
/usr/lib/${DEB_HOST_MULTIARCH}/… instead of /usr/lib/*/…
--
Cheers,
tobi
Attachment:
signature.asc
Description: PGP signature