Hi Sean, Thanks for taking care of it! Please also see the replies below inline. Sean Whitton <spwhitton@spwhitton.name> writes: > Hello, > > On Sat 09 Dec 2023 at 04:23pm GMT, Sean Whitton wrote: > >> Hello Xiyue, >> >> I made some commits before uploading. Please review. >> >> For the dgit-maint-merge(7) workflow, there is no need to manually >> refresh patches. dgit will do it for us whenever necessary. See the >> automatic commit now on the branch. Ack. Looks like I was still using the old quilt-based approach. Will take a look at how dgit does it. > > Hmm. Looks like I might have deleted some changes. Could you take a > look? Thank you. Looks like the deleted changes are the patches that dropped the package.el based installation instructions from README.md and an extra loading path of Eldev based directory. I don't think they'll matter much to be honest (especially the latter doesn't cause any issue for the tests), so please feel free to leave them as is. -- Xiyue Deng
Attachment:
signature.asc
Description: PGP signature