[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#1055332: RFS: hunspell-be/0.60-1 -- Belarusian dictionary for hunspell and academic orthography



Hleb,


Thanks for working on this.  I see a few minor packaging issues you might want to address before this is uploaded.  These can be seen at:


https://mentors.debian.net/package/hunspell-be/


1.  conflicts-with-version openoffice.org (<= 1.0.3-2)


OpenOffice is no longer in Debian, so you could remove this conflicts.


2.  out-of-date-standards-version 4.4.0 (released 2019-07-07) (current is 4.6.2)


You should update the standards version, making any necessary changess.


https://www.debian.org/doc/debian-policy/upgrading-checklist.html


3.  package-uses-old-debhelper-compat-version 12


Bump the compat version to 13.


4.  silent-on-rules-requiring-root [debian/control]


https://www.debian.org/doc/debian-policy/ch-controlfields.html#s-f-rules-requires-root


If you don’t need root to build your package, it is as simple as adding the following line:


https://salsa.debian.org/sorenstoutner/privacybrowser/-/blob/master/debian/control#L27


5.  debian-watch-does-not-check-openpgp-signature [debian/watch]


Assuming upstream signs their releases, you should enable verifying it.


https://wiki.debian.org/debian/watch#Cryptographic_signature_verification


6.  upstream-metadata-file-is-missing


You should add this file according to the documentation at:


https://wiki.debian.org/UpstreamMetadata


An example file in one of the packages I maintain is:


https://salsa.debian.org/sorenstoutner/privacybrowser/-/blob/master/debian/upstream/metadata


7.  No VCS field present


You should populate the Vcs-browser field, which is the VCS for browsing your packaging information.


https://github.com/375gnu/hunspell-be


You can see an example of where this field goes at:


https://salsa.debian.org/sorenstoutner/privacybrowser/-/blob/master/debian/control#L26


You should also add the VCS-Git filed:


https://github.com/375gnu/hunspell-be.git


8.  Upstream-Contact missing from d/copyright

Upstream Contact:    None

Licenses:    CC-BY-SA


You should add the upstream contact information, similar to:


https://salsa.debian.org/sorenstoutner/privacybrowser/-/blob/master/debian/copyright#L3


This information appears to be available at:


https://github.com/mikalai-udodau/spell-be/blob/master/README_spell_be_BY.txt#L6



On Saturday, November 4, 2023 5:08:02 AM MST Hleb Valoshka wrote:

> Package: sponsorship-requests

> Severity: normal

>

> Dear mentors,

>

> I am looking for a sponsor for my package "hunspell-be":

>

>  * Package name     : hunspell-be

>    Version          : 0.60-1

>    Upstream contact : Mikalai Udodau <mikalai.udodau@gmail.com>

>  * URL              : https://github.com/mikalai-udodau/spell-be/

>  * License          : CC-BY-SA

>  * Vcs              : git@github.com:375gnu/hunspell-be.git

>    Section          : text

>

> The source builds the following binary packages:

>

>   hunspell-be - Belarusian dictionary for hunspell and academic orthography

>

> To access further information about this package, please visit the

> following URL:

>

>   https://mentors.debian.net/package/hunspell-be/

>

> Alternatively, you can download the package with 'dget' using this command:

>

>   dget -x

> https://mentors.debian.net/debian/pool/main/h/hunspell-be/hunspell-be_0.60-

> 1.dsc

>

> Changes since the last upload:

>

>  hunspell-be (0.60-1) unstable; urgency=medium

>  .

>    [ Soren Stoutner ]

>    * debian/control: Build-depends on convert-bdic. (Closes: #1020480)

>    * debian/rules: Build and clean the .bdic binary dictionary file.

>    * debian/hunspell-be.install: Install the .bdic binary dictionary to

>      /usr/share/hunspell-bdic/.

>  .

>    [ Hleb Valoshka ]

>    * Update d/watch to return only the latest release

>    * New upstream version 0.60

>    * Update d/control with the new upstream address

>    * Update copyright information

>

> Regards,



--

Soren Stoutner

soren@stoutner.com

Attachment: signature.asc
Description: This is a digitally signed message part.


Reply to: